CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c8e440950082a2b7f5eae1410264f75acdd0885
Cr-Commit-Position: refs/heads/master@{#377501}

[loyso (OOO), 2016-02-15 06:30:58]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

BUG=577016
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-15 06:43:09]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

AN UNFINISHED DEMO.

AnimationTargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorAnimationTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

Consider an alternative approach with strongly typed enum:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-15 06:43:09]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, danakj@chromium.org, esprehn@chromium.org,
jbroman@chromium.org, vollick@chromium.org

[loyso (OOO), 2016-02-15 06:43:28]

PTAL! Which approach is better?

[loyso (OOO), 2016-02-15 22:52:58]

Any suggestions/opinions please?

[loyso (OOO), 2016-02-16 06:17:37]

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
File cc/animation/animation_target_property.h (right):

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
cc/animation/animation_target_property.h:10: struct AnimationTargetProperty {
This can be a namespace AnimationTargetProperty

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
cc/animation/animation_target_property.h:11: enum Enum {
Alternatively, we could go with global old-style enum
ANIMATION_TARGET_PROPERTY_TRANSFORM etc in cc namespace (which is weird and
unbound)

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
cc/animation/animation_target_property.h:22: const char*
GetAnimationTargetPropertyName(
This can be a member function.

[loyso (OOO), 2016-02-17 01:27:29]

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
File cc/animation/animation_target_property.h (right):

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
cc/animation/animation_target_property.h:11: enum Enum {
On 2016/02/16 06:17:37, loyso wrote:
> Alternatively, we could go with global old-style enum
> ANIMATION_TARGET_PROPERTY_TRANSFORM etc in cc namespace (which is weird and
> unbound)
But old-style enum would not work for 'using' in blink. I.e. you can't write:
using CompositorAnimationTargetProperty = cc::AnimationTargetProperty if
AnimationTargetProperty is a enum. That's why we need a class around it.

[loyso (OOO), 2016-02-17 05:26:23]

loyso@chromium.org changed reviewers:
+ enne@chromium.org
- jbroman@chromium.org

[Ian Vollick, 2016-02-17 13:43:27]

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
File cc/animation/animation_target_property.h (right):

https://codereview.chromium.org/1700653002/diff/1/cc/animation/animation_targ...
cc/animation/animation_target_property.h:11: enum Enum {
On 2016/02/17 01:27:29, loyso wrote:
> On 2016/02/16 06:17:37, loyso wrote:
> > Alternatively, we could go with global old-style enum
> > ANIMATION_TARGET_PROPERTY_TRANSFORM etc in cc namespace (which is weird and
> > unbound)
> But old-style enum would not work for 'using' in blink. I.e. you can't write:
> using CompositorAnimationTargetProperty = cc::AnimationTargetProperty if
> AnimationTargetProperty is a enum. That's why we need a class around it.

Right, I like this approach for pulling the enum into blink. It mirrors what
Dana suggested I do here: https://codereview.chromium.org/1599673002/

[loyso (OOO), 2016-02-19 01:52:33]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

AN UNFINISHED DEMO.

AnimationTargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorAnimationTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

Consider an alternative approach with strongly typed enum:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

Consider an alternative approach with strongly typed enum:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-02-19 01:56:16]

Everyone, PTAL! This is ready to be landed.

[Ian Vollick, 2016-02-22 01:24:53]

On 2016/02/19 01:56:16, loyso wrote:
> Everyone, PTAL! This is ready to be landed.

lgtm.

[loyso (OOO), 2016-02-23 04:10:20]

PTAL! (WebKit/Source)

[loyso (OOO), 2016-02-23 22:53:32]

loyso@chromium.org changed reviewers:
+ aelias@chromium.org

[loyso (OOO), 2016-02-23 22:54:10]

aelias@, web/LinkHighlightImpl.cpp PTAL!

[aelias_OOO_until_Jul13, 2016-02-24 00:28:58]

Source/web lgtm

[loyso (OOO), 2016-02-24 03:57:07]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

Consider an alternative approach with strongly typed enum:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[esprehn, 2016-02-24 23:11:21]

lgtm

[loyso (OOO), 2016-02-25 01:26:56]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-02-25 01:26:57]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
vollick@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1700653002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-02-25 01:30:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700653002/60001

[commit-bot: I haz the power, 2016-02-25 03:07:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 03:07:32]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[loyso (OOO), 2016-02-25 04:01:45]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-02-25 04:02:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700653002/60001

[commit-bot: I haz the power, 2016-02-25 04:12:37]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-25 04:12:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-25 04:13:54]

Description was changed from

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Expose TargetProperty enum to be aliased in Blink Platform.

TargetProperty is intended to be used as an alias in
Source/platform/animation/CompositorTargetProperty.h

This is slightly better then untyped approach used here:
https://codereview.chromium.org/1599673002
where we setup struct with constants in it and pass uint32_t everywhere.

An alternative approach with strongly typed enum
considered too verbose:
https://codereview.chromium.org/1698813002/

BUG=577016
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c8e440950082a2b7f5eae1410264f75acdd0885
Cr-Commit-Position: refs/heads/master@{#377501}
==========

[commit-bot: I haz the power, 2016-02-25 04:13:55]

Patchset 4 (id:??) landed as
https://crrev.com/0c8e440950082a2b7f5eae1410264f75acdd0885
Cr-Commit-Position: refs/heads/master@{#377501}