Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: cc/animation/animation_target_property.h

Issue 1700653002: CC Animation: Expose TargetProperty enum to be aliased in Blink Platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/animation/animation_player_unittest.cc ('k') | cc/animation/animation_target_property.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CC_ANIMATION_ANIMATION_TARGET_PROPERTY_H_
6 #define CC_ANIMATION_ANIMATION_TARGET_PROPERTY_H_
7
8 namespace cc {
9
10 struct AnimationTargetProperty {
loyso (OOO) 2016/02/16 06:17:37 This can be a namespace AnimationTargetProperty
11 enum Enum {
loyso (OOO) 2016/02/16 06:17:37 Alternatively, we could go with global old-style e
loyso (OOO) 2016/02/17 01:27:29 But old-style enum would not work for 'using' in b
Ian Vollick 2016/02/17 13:43:27 Right, I like this approach for pulling the enum i
12 TRANSFORM = 0,
13 OPACITY,
14 FILTER,
15 SCROLL_OFFSET,
16 BACKGROUND_COLOR,
17 // This sentinel must be last.
18 LAST_TARGET_PROPERTY = BACKGROUND_COLOR
19 };
20 };
21
22 const char* GetAnimationTargetPropertyName(
loyso (OOO) 2016/02/16 06:17:36 This can be a member function.
23 AnimationTargetProperty::Enum property);
24
25 } // namespace cc
26
27 #endif // CC_ANIMATION_ANIMATION_TARGET_PROPERTY_H_
OLDNEW
« no previous file with comments | « cc/animation/animation_player_unittest.cc ('k') | cc/animation/animation_target_property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698