Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2748)

Unified Diff: chrome/renderer/media/cast_rtp_stream.h

Issue 170063006: Cast: Add JS API to get raw events logs from cast extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed alpha's comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/media/cast_rtp_stream.h
diff --git a/chrome/renderer/media/cast_rtp_stream.h b/chrome/renderer/media/cast_rtp_stream.h
index f3a06c0e317108a6d55607a4da294acf1c845526..1071ff91efe61a16acaff21749740d1c0dcf8b52 100644
--- a/chrome/renderer/media/cast_rtp_stream.h
+++ b/chrome/renderer/media/cast_rtp_stream.h
@@ -117,6 +117,15 @@ class CastRtpStream {
// Stop encoding.
void Stop();
+ void SetStreamId(const int stream_id);
Alpha Left Google 2014/02/24 23:25:51 Stream ID doesn't belong to CastRtpStream.
imcheng 2014/02/25 08:10:18 See other reply
+
+ // Enables or disables logging for this stream.
+ void ToggleLogging(const bool enable);
Alpha Left Google 2014/02/24 23:25:51 nit: there's no need to make this const.
imcheng 2014/02/25 08:10:18 Done.
+
+ // Get serialized raw events for this stream and invokes |callback|
+ // with the result.
+ void GetRawEvents(base::Callback<void(scoped_ptr<std::string>)> callback);
+
private:
// Return true if this track is an audio track. Return false if this
// track is a video track.
@@ -129,6 +138,7 @@ class CastRtpStream {
scoped_ptr<CastAudioSink> audio_sink_;
scoped_ptr<CastVideoSink> video_sink_;
CastRtpParams params_;
+ int stream_id_;
base::WeakPtrFactory<CastRtpStream> weak_factory_;
base::Closure stop_callback_;
ErrorCallback error_callback_;

Powered by Google App Engine
This is Rietveld 408576698