Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5097)

Unified Diff: chrome/renderer/media/cast_session.h

Issue 170063006: Cast: Add JS API to get raw events logs from cast extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed alpha's comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/media/cast_session.h
diff --git a/chrome/renderer/media/cast_session.h b/chrome/renderer/media/cast_session.h
index 720821fb575054017e9a00fbeed13ba8545b3033..170b61e9dc3d1b735dc40a07475c93b526cef4fb 100644
--- a/chrome/renderer/media/cast_session.h
+++ b/chrome/renderer/media/cast_session.h
@@ -57,8 +57,18 @@ class CastSession : public base::RefCounted<CastSession> {
void StartUDP(const net::IPEndPoint& local_endpoint,
const net::IPEndPoint& remote_endpoint);
- // Get raw event logs and provide the results in |callback| on main thread.
- void GetEventLogsAndReset(const EventLogsCallback& callback);
+ // Creates or destroys event subscriber for a stream with |stream_id|.
+ // The subscriber will process audio or video events depending on |is_audio|.
+ // |enable|: If true, creates an event subscriber. Otherwise destroys
+ // existing subscriber and discards logs.
+ void ToggleLogging(const int stream_id,
Alpha Left Google 2014/02/24 23:25:51 You already have |is_audio|. Is |stream_id| useful
imcheng 2014/02/25 08:10:18 See other reply.
+ const bool enable,
+ const bool is_audio);
+
+ // Returns raw event logs in serialized format for |stream_id| since
+ // last call and returns result in |callback|.
+ void GetEventLogsAndReset(const EventLogsCallback& callback,
+ const int stream_id);
private:
friend class base::RefCounted<CastSession>;

Powered by Google App Engine
This is Rietveld 408576698