Make FYI bot test script exit with nonzero status if any tests fail.

Make FYI bot test script exit with nonzero status if any tests fail.

The PNaCl FYI bots are getting errors running torture and LLVM testsuite
tests but the bots are showing as green. I suspect that previously the
build waterfall would show the bot as red if any step was red (i.e. the
script emitted @@@STEP_FAILURE@@@ but at some point it changed to be
based on the exit status of the script.

BUG=green bots
R=mseaborn@chromium.org, stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/2e74411b4f527517515dd5885104834a6907e604

[Derek Schuff, 2016-02-12 23:44:59]

dschuff@chromium.org changed reviewers:
+ jpp@chromium.org, mseaborn@chromium.org, phosek@chromium.org,
smklein@google.com, stichnot@chromium.org

[Derek Schuff, 2016-02-12 23:44:59]

I just noticed that the x86 FYI bots have recently started getting test failures
(e.g. if you click on the individual builds listed at
https://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_6...
you'll see the red steps) Presumably this is related to recent PNaCl or subzero
work but I haven't investigated.

[Mark Seaborn, 2016-02-12 23:53:40]

Yeah, I noticed this problem too.  I wondered why my validator change didn't
show up as red, while later in-progress builds were yellow-with-red-edges.

LGTM.  Should you do a trybot run to test this change before committing?  Isn't
this script run by the toolchain trybots?

[Derek Schuff, 2016-02-12 23:57:48]

On 2016/02/12 23:53:40, Mark Seaborn wrote:
> Yeah, I noticed this problem too.  I wondered why my validator change didn't
> show up as red, while later in-progress builds were yellow-with-red-edges.
> 
> LGTM.  Should you do a trybot run to test this change before committing? 
Isn't
> this script run by the toolchain trybots?

No, this script is only run by the FYI bots.

[Jim Stichnoth, 2016-02-13 00:02:35]

lgtm

[Derek Schuff, 2016-02-13 00:54:55]

Description was changed from

==========
Make FYI bot test script exit with nonzero status if any tests fail.

The PNaCl FYI bots are getting errors running torture and LLVM testsuite
tests but the bots are showing as green. I suspect that previously the
build waterfall would show the bot as red if any step was red (i.e. the
script emitted @@@STEP_FAILURE@@@ but at some point it changed to be
based on the exit status of the script.

BUG=green bots
==========

to

==========
Make FYI bot test script exit with nonzero status if any tests fail.

The PNaCl FYI bots are getting errors running torture and LLVM testsuite
tests but the bots are showing as green. I suspect that previously the
build waterfall would show the bot as red if any step was red (i.e. the
script emitted @@@STEP_FAILURE@@@ but at some point it changed to be
based on the exit status of the script.

BUG=green bots
R=mseaborn@chromium.org, stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/2e74411b4...
==========

[Derek Schuff, 2016-02-13 00:54:57]

Committed patchset #1 (id:1) manually as
2e74411b4f527517515dd5885104834a6907e604 (presubmit successful).