PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

Previously, the '-stdlib=libc++' flag was sufficient to remove the system C++
headers from the search path because there were no libc++ headers available.
With the recent Chromium clang update, the compiler includes its own libc++
headers, which conflict with our libc++ headers that we manually include.
So also add -nostdinc++ so that we only get one set of libc++ headers.

R=mcgrathr@chromium.org, stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/7f3183734c7927a12700fcf0a29d6baf340a318b

[Derek Schuff, 2016-01-20 17:58:25]

This gets us back to the previous status quo. We should still switch to static
libc++ in the future, hopefully for both mac and Linux.

[Derek Schuff, 2016-01-20 18:10:07]

Description was changed from

==========
PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

Previously, the '-stdlib=libc++' flag was sufficient to remove the system C++
headers from the search path because there were no libc++ headers available.
With the recent Chromium clang update, the compiler includes its own libc++
headers, which conflict with our libc++ headers that we manually include.
So also add -nostdinc++ so that we only get one set of libc++ headers.

R=mcgrathr@chromium.org
==========

to

==========
PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

Previously, the '-stdlib=libc++' flag was sufficient to remove the system C++
headers from the search path because there were no libc++ headers available.
With the recent Chromium clang update, the compiler includes its own libc++
headers, which conflict with our libc++ headers that we manually include.
So also add -nostdinc++ so that we only get one set of libc++ headers.

R=mcgrathr@chromium.org
==========

[Derek Schuff, 2016-01-20 18:10:07]

dschuff@chromium.org changed reviewers:
+ mseaborn@chromium.org, stichnot@chromium.org

[Derek Schuff, 2016-01-20 18:10:17]

On 2016/01/20 17:58:25, Derek Schuff wrote:
> This gets us back to the previous status quo. We should still switch to static
> libc++ in the future, hopefully for both mac and Linux.

+Jim and Mark

[Jim Stichnoth, 2016-01-20 18:17:26]

lgtm

[Roland McGrath, 2016-01-20 18:41:39]

lgtm

[Derek Schuff, 2016-01-20 18:52:56]

Description was changed from

==========
PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

Previously, the '-stdlib=libc++' flag was sufficient to remove the system C++
headers from the search path because there were no libc++ headers available.
With the recent Chromium clang update, the compiler includes its own libc++
headers, which conflict with our libc++ headers that we manually include.
So also add -nostdinc++ so that we only get one set of libc++ headers.

R=mcgrathr@chromium.org
==========

to

==========
PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++

Previously, the '-stdlib=libc++' flag was sufficient to remove the system C++
headers from the search path because there were no libc++ headers available.
With the recent Chromium clang update, the compiler includes its own libc++
headers, which conflict with our libc++ headers that we manually include.
So also add -nostdinc++ so that we only get one set of libc++ headers.

R=mcgrathr@chromium.org, stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/7f3183734...
==========

[Derek Schuff, 2016-01-20 18:52:57]

Committed patchset #1 (id:1) manually as
7f3183734c7927a12700fcf0a29d6baf340a318b (tree was closed).