Issue 1700483002: [sqlite] iOS running recover virtual table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1700483002: [sqlite] iOS running recover virtual table. (Closed)

Created:
4 years, 10 months ago by Scott Hess - ex-Googler

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@zzsql_recover_handle_review2

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[sqlite] iOS running recover virtual table. Test that the table works when running externally on iOS.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -4673 lines)			Patch
M	sql/recovery.cc	View		4 chunks	+2 lines, -17 lines	0 comments	Download
M	sql/recovery_unittest.cc	View	1	4 chunks	+60 lines, -5 lines	0 comments	Download
M	third_party/sqlite/amalgamation/sqlite3.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	third_party/sqlite/amalgamation/sqlite3.c	View		2 chunks	+0 lines, -2300 lines	0 comments	Download
A	third_party/sqlite/ext/recover.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A +	third_party/sqlite/ext/recover.c	View		15 chunks	+223 lines, -29 lines	0 comments	Download
M	third_party/sqlite/sqlite.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/sqlite/src/Makefile.in	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/sqlite/src/main.mk	View		4 chunks	+6 lines, -6 lines	0 comments	Download
D	third_party/sqlite/src/src/recover.c	View		1 chunk	+0 lines, -2281 lines	0 comments	Download
M	third_party/sqlite/src/src/sqlite.h.in	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	third_party/sqlite/src/tool/mksqlite3c.tcl	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Depends on Patchset:

Total messages: 2 (1 generated)

Manually find sql/test/data for now.