Clone both descriptor and data array when compiling in background

Clone both descriptor and data array when compiling in background. Eliminates crashes when ic_data array invocation counter is changed while compiling (e.g., NumberOfUsedChecks can change on the fly).

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/420843a75f3731437195d0ebc70a75bbc86efcc2

[srdjan, 2016-02-12 21:45:35]

Description was changed from

==========
Clone both descriptor and data array when compiling in background

BUG=
==========

to

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array incvocation counter is changed while compiling.

BUG=
==========

[srdjan, 2016-02-12 21:45:46]

Description was changed from

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array incvocation counter is changed while compiling.

BUG=
==========

to

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array invocation counter is changed while compiling.

BUG=
==========

[srdjan, 2016-02-12 21:46:19]

Description was changed from

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array invocation counter is changed while compiling.

BUG=
==========

to

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array invocation counter is changed while compiling (e.g.,
NumberOfUsedChecks can change on the fly).

BUG=
==========

[srdjan, 2016-02-12 21:49:31]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-02-12 22:10:25]

lgtm

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12327: }
I think there are many places where we do this array copy, maybe we should have
a makeCopy method in array that can be used in all these places. I will do that
in a different cl.

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:1948: static RawICData* CloneDescriptorAndData(const ICData&
from);
Why not call it Clone?

[srdjan, 2016-02-12 22:20:38]

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:12327: }
On 2016/02/12 22:10:24, siva wrote:
> I think there are many places where we do this array copy, maybe we should
have
> a makeCopy method in array that can be used in all these places. I will do
that
> in a different cl.

Sounds good.

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/1700463002/diff/20001/runtime/vm/object.h#new...
runtime/vm/object.h:1948: static RawICData* CloneDescriptorAndData(const ICData&
from);
On 2016/02/12 22:10:25, siva wrote:
> Why not call it Clone?

Renamed to Clone

[srdjan, 2016-02-12 22:54:58]

Description was changed from

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array invocation counter is changed while compiling (e.g.,
NumberOfUsedChecks can change on the fly).

BUG=
==========

to

==========
Clone both descriptor and data array when compiling in background. Eliminates
crashes when ic_data array invocation counter is changed while compiling (e.g.,
NumberOfUsedChecks can change on the fly).

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/420843a75f3731437195d0ebc70a75bbc86efcc2
==========

[srdjan, 2016-02-12 22:54:59]

Committed patchset #4 (id:60001) manually as
420843a75f3731437195d0ebc70a75bbc86efcc2 (presubmit successful).