runtime/vm/coverage.cc - Issue 1700463002: Clone both descriptor and data array when compiling in background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/coverage.cc

Issue 1700463002: Clone both descriptor and data array when compiling in background (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Reviewer's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/coverage.cc

diff --git a/runtime/vm/coverage.cc b/runtime/vm/coverage.cc

index 8ce260be1b624e788c19276417ad20d29e9f7770..2e85c3d25b10afa5ff2f1ac71c0a031fbcea9274 100644

--- a/runtime/vm/coverage.cc

+++ b/runtime/vm/coverage.cc

@@ -89,7 +89,7 @@ void CodeCoverage::CompileAndAdd(const Function& function,

// Print the hit counts for all IC datas.

ZoneGrowableArray<const ICData*>* ic_data_array =

new(zone) ZoneGrowableArray<const ICData*>();

- function.RestoreICDataMap(ic_data_array, false /* clone descriptors */);

+ function.RestoreICDataMap(ic_data_array, false /* clone ic-data */);

const PcDescriptors& descriptors = PcDescriptors::Handle(

zone, code.pc_descriptors());

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_inliner.cc » ('j') | no next file with comments »