Issue 17004011: drive: DriveIntegrationService owns ResourceMetadataStorage

Issue 17004011: drive: DriveIntegrationService owns ResourceMetadataStorage (Closed)

Created:
7 years, 6 months ago by hashimoto

Modified:
7 years, 6 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: DriveIntegrationService owns ResourceMetadataStorage To share ResourceMetadataStorage with FileCache, the ownership of the storage is moved from ResourceMetadata. BUG=234487 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207742

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix a nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -97 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_loader_unittest.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_processor_unittest.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View		6 chunks	+17 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/operation_test_base.cc	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View		4 chunks	+17 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata.h	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata.cc	View		12 chunks	+14 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.h	View		5 chunks	+23 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage.cc	View		4 chunks	+22 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc	View		6 chunks	+15 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_unittest.cc	View		5 chunks	+29 lines, -35 lines	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata_unittest.cc	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinaba

lgtm with a nit https://codereview.chromium.org/17004011/diff/3001/chrome/browser/chromeos/drive/file_system/operation_test_base.cc File chrome/browser/chromeos/drive/file_system/operation_test_base.cc (left): https://codereview.chromium.org/17004011/diff/3001/chrome/browser/chromeos/drive/file_system/operation_test_base.cc#oldcode81 chrome/browser/chromeos/drive/file_system/operation_test_base.cc:81: bool success = false; It ...

7 years, 6 months ago (2013-06-21 06:41:18 UTC) #2

hashimoto

https://codereview.chromium.org/17004011/diff/3001/chrome/browser/chromeos/drive/file_system/operation_test_base.cc File chrome/browser/chromeos/drive/file_system/operation_test_base.cc (left): https://codereview.chromium.org/17004011/diff/3001/chrome/browser/chromeos/drive/file_system/operation_test_base.cc#oldcode81 chrome/browser/chromeos/drive/file_system/operation_test_base.cc:81: bool success = false; On 2013/06/21 06:41:18, kinaba wrote: ...

7 years, 6 months ago (2013-06-21 07:03:17 UTC) #3

hashimoto

7 years, 6 months ago (2013-06-21 07:09:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r207742 (presubmit successful).

Expand Messages | Collapse Messages