Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc

Issue 17004011: drive: DriveIntegrationService owns ResourceMetadataStorage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a nit Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc
diff --git a/chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc b/chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc
index ae57e6580c7064910ecbb38c1bca33495876eb22..4ab0acfc008df5339e4ffef6e7603d88f8e6bbff 100644
--- a/chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc
+++ b/chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc
@@ -9,23 +9,24 @@
#include "base/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "chrome/browser/chromeos/drive/drive.pb.h"
+#include "chrome/browser/chromeos/drive/test_util.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/leveldatabase/src/include/leveldb/db.h"
namespace drive {
+namespace internal {
class ResourceMetadataStorageTest : public testing::Test {
protected:
virtual void SetUp() OVERRIDE {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- storage_.reset(new ResourceMetadataStorage(temp_dir_.path()));
+ storage_.reset(new ResourceMetadataStorage(
+ temp_dir_.path(), base::MessageLoopProxy::current()));
ASSERT_TRUE(storage_->Initialize());
}
- virtual void TearDown() OVERRIDE {
- }
-
// Overwrites |storage_|'s version.
void SetDBVersion(int version) {
ResourceMetadataHeader header;
@@ -58,8 +59,10 @@ class ResourceMetadataStorageTest : public testing::Test {
child_base_name));
}
+ content::TestBrowserThreadBundle thread_bundle_;
base::ScopedTempDir temp_dir_;
- scoped_ptr<ResourceMetadataStorage> storage_;
+ scoped_ptr<ResourceMetadataStorage,
+ test_util::DestroyHelperForTests> storage_;
};
TEST_F(ResourceMetadataStorageTest, LargestChangestamp) {
@@ -308,7 +311,8 @@ TEST_F(ResourceMetadataStorageTest, OpenExistingDB) {
EXPECT_TRUE(storage_->PutEntry(entry2));
// Close DB and reopen.
- storage_.reset(new ResourceMetadataStorage(temp_dir_.path()));
+ storage_.reset(new ResourceMetadataStorage(
+ temp_dir_.path(), base::MessageLoopProxy::current()));
ASSERT_TRUE(storage_->Initialize());
// Can read data.
@@ -339,7 +343,8 @@ TEST_F(ResourceMetadataStorageTest, IncompatibleDB) {
// Set incompatible version and reopen DB.
SetDBVersion(ResourceMetadataStorage::kDBVersion - 1);
- storage_.reset(new ResourceMetadataStorage(temp_dir_.path()));
+ storage_.reset(new ResourceMetadataStorage(
+ temp_dir_.path(), base::MessageLoopProxy::current()));
ASSERT_TRUE(storage_->Initialize());
// Data is erased because of the incompatible version.
@@ -352,7 +357,8 @@ TEST_F(ResourceMetadataStorageTest, WrongPath) {
base::FilePath path;
ASSERT_TRUE(file_util::CreateTemporaryFileInDir(temp_dir_.path(), &path));
- storage_.reset(new ResourceMetadataStorage(path));
+ storage_.reset(new ResourceMetadataStorage(
+ path, base::MessageLoopProxy::current()));
// Cannot initialize DB beacause the path does not point a directory.
ASSERT_FALSE(storage_->Initialize());
}
@@ -434,4 +440,5 @@ TEST_F(ResourceMetadataStorageTest, CheckValidity) {
EXPECT_TRUE(CheckValidity());
}
+} // namespace internal
} // namespace drive

Powered by Google App Engine
This is Rietveld 408576698