Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1700383002: [MD] Fix clipping of infobar child elements (particularly close button). (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
Peter Kasting, bruthig
CC:
chromium-reviews, tfarina, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Fix clipping of infobar child elements (particularly close button). The bounds of the InfoBarView extend above the toolbar separator so adding a layer to it doesn't help us mask the bar contents. Instead, add an intermediate view that holds the bar elements. BUG=585512 Committed: https://crrev.com/471d68791ba3d545feae2850ff32d61d6e076784 Cr-Commit-Position: refs/heads/master@{#376019}

Patch Set 1 #

Patch Set 2 : adjust comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -50 lines) Patch
M chrome/browser/ui/views/dropdown_bar_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 1 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 7 chunks +30 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Evan Stade
4 years, 10 months ago (2016-02-17 00:55:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700383002/20001
4 years, 10 months ago (2016-02-17 00:58:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 01:42:21 UTC) #6
Peter Kasting
LGTM
4 years, 10 months ago (2016-02-17 02:59:26 UTC) #7
bruthig
lgtm
4 years, 10 months ago (2016-02-17 14:46:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700383002/20001
4 years, 10 months ago (2016-02-17 22:46:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 22:56:50 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/471d68791ba3d545feae2850ff32d61d6e076784 Cr-Commit-Position: refs/heads/master@{#376019}
4 years, 10 months ago (2016-02-17 22:57:53 UTC) #13
kirr
FYI: This CL causes funny regression. Infobars now grows after every tab switching. https://drive.google.com/file/d/0ByXTnneU3LLDcUtidmhNeTduRDA/view
4 years, 10 months ago (2016-02-20 14:37:51 UTC) #14
Peter Kasting
4 years, 10 months ago (2016-02-21 21:48:25 UTC) #15
Message was sent while issue was closed.
On 2016/02/20 14:37:51, kirr wrote:
> FYI:
> This CL causes funny regression.
> Infobars now grows after every tab switching.
> https://drive.google.com/file/d/0ByXTnneU3LLDcUtidmhNeTduRDA/view

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=588509 for this.

Powered by Google App Engine
This is Rietveld 408576698