Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/ui/views/dropdown_bar_host.h

Issue 1700383002: [MD] Fix clipping of infobar child elements (particularly close button). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/dropdown_bar_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_
6 #define CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_ 6 #define CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 147
148 private: 148 private:
149 // Set the view whose position in the |browser_view_| view hierarchy 149 // Set the view whose position in the |browser_view_| view hierarchy
150 // determines the z-order of |host_| relative to views with layers and 150 // determines the z-order of |host_| relative to views with layers and
151 // views with associated NativeViews. 151 // views with associated NativeViews.
152 void SetHostViewNative(views::View* host_view); 152 void SetHostViewNative(views::View* host_view);
153 153
154 // The BrowserView that created us. 154 // The BrowserView that created us.
155 BrowserView* browser_view_; 155 BrowserView* browser_view_;
156 156
157 // A parent View to |view_| that is used to clip when animating the bar
158 // between the shown and hidden states.
159 views::View* clip_view_;
160
161 // Our view, which is responsible for drawing the UI. 157 // Our view, which is responsible for drawing the UI.
162 views::View* view_; 158 views::View* view_;
163 DropdownBarHostDelegate* delegate_; 159 DropdownBarHostDelegate* delegate_;
164 160
165 // The animation class to use when opening the Dropdown widget. 161 // The animation class to use when opening the Dropdown widget.
166 scoped_ptr<gfx::SlideAnimation> animation_; 162 scoped_ptr<gfx::SlideAnimation> animation_;
167 163
168 // The focus manager we register with to keep track of focus changes. 164 // The focus manager we register with to keep track of focus changes.
169 views::FocusManager* focus_manager_; 165 views::FocusManager* focus_manager_;
170 166
(...skipping 10 matching lines...) Expand all
181 scoped_ptr<views::Widget> host_; 177 scoped_ptr<views::Widget> host_;
182 178
183 // A flag to manually manage visibility. GTK/X11 is asynchronous and 179 // A flag to manually manage visibility. GTK/X11 is asynchronous and
184 // the state of the widget can be out of sync. 180 // the state of the widget can be out of sync.
185 bool is_visible_; 181 bool is_visible_;
186 182
187 DISALLOW_COPY_AND_ASSIGN(DropdownBarHost); 183 DISALLOW_COPY_AND_ASSIGN(DropdownBarHost);
188 }; 184 };
189 185
190 #endif // CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_ 186 #endif // CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/dropdown_bar_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698