Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1700313002: Remove gfx::JPEGCodec. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove gfx::JPEGCodec. I'll remove libjpeg_turbo, libjpeg, and yasm separately (I *think* can remove all those). Also DONT_EMBED_BUILD_METADATA. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/84cb1e4135d4052700bbfe002e986cd64a3f5eb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -925 lines) Patch
M ui/gfx/BUILD.gn View 4 chunks +2 lines, -7 lines 0 comments Download
D ui/gfx/codec/jpeg_codec.h View 1 chunk +0 lines, -79 lines 0 comments Download
D ui/gfx/codec/jpeg_codec.cc View 1 chunk +0 lines, -622 lines 0 comments Download
D ui/gfx/codec/jpeg_codec_unittest.cc View 1 chunk +0 lines, -217 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-16 21:40:19 UTC) #1
jamesr
lgtm (assuming bots roll green)
4 years, 10 months ago (2016-02-16 21:42:52 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-16 21:43:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84cb1e4135d4052700bbfe002e986cd64a3f5eb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698