Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1700273003: MD Settings: make <paper-drawer-panel> flip in RTL (Closed)

Created:
4 years, 10 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make <paper-drawer-panel> flip in RTL R=michaelpg@chromium.org BUG=586579 Committed: https://crrev.com/98b969da7999ff1b3b25fb7ac295d9afcbff2d35 Cr-Commit-Position: refs/heads/master@{#376071}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixted #

Patch Set 3 : combining tests #

Total comments: 3

Patch Set 4 : compile #

Total comments: 7

Patch Set 5 : michaelpg@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -15 lines) Patch
M chrome/browser/resources/settings/compiled_resources2.gyp View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/direction_delegate.html View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/direction_delegate.js View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings.js View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 3 4 3 chunks +29 lines, -6 lines 0 comments Download
A chrome/test/data/webui/settings/rtl_tests.js View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
Dan Beam
https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js#newcode28 chrome/browser/resources/settings/settings_ui/settings_ui.js:28: assert(!document.documentElement.dir); if this changes (i.e. dschuyler does <html dir="$i18n{textdirection}"> ...
4 years, 10 months ago (2016-02-17 04:47:35 UTC) #1
michaelpg
https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js#newcode29 chrome/browser/resources/settings/settings_ui/settings_ui.js:29: this.listen(document, 'i18n-processed', 'onI18nProcessed_'); On 2016/02/17 04:47:34, Dan Beam wrote: ...
4 years, 10 months ago (2016-02-17 06:14:05 UTC) #2
Dan Beam
https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js File chrome/browser/resources/settings/settings_ui/settings_ui.js (right): https://codereview.chromium.org/1700273003/diff/1/chrome/browser/resources/settings/settings_ui/settings_ui.js#newcode29 chrome/browser/resources/settings/settings_ui/settings_ui.js:29: this.listen(document, 'i18n-processed', 'onI18nProcessed_'); On 2016/02/17 06:14:05, michaelpg wrote: > ...
4 years, 10 months ago (2016-02-17 17:55:55 UTC) #3
Dan Beam
so hold off on reviewing this as I'm going to move the mocha tests to ...
4 years, 10 months ago (2016-02-17 18:02:44 UTC) #4
Dan Beam
ok, ready now https://codereview.chromium.org/1700273003/diff/40001/chrome/browser/resources/settings/settings_resources.grd File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/1700273003/diff/40001/chrome/browser/resources/settings/settings_resources.grd#newcode215 chrome/browser/resources/settings/settings_resources.grd:215: file="direction_delegate.html" I don't really think making ...
4 years, 10 months ago (2016-02-17 19:57:12 UTC) #5
Dan Beam
https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/cr_settings_browsertest.js File chrome/test/data/webui/settings/cr_settings_browsertest.js (right): https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/cr_settings_browsertest.js#newcode57 chrome/test/data/webui/settings/cr_settings_browsertest.js:57: // TODO(dbeam): these should be split into multiple TEST_F()s. ...
4 years, 10 months ago (2016-02-17 20:01:37 UTC) #6
michaelpg
lgtm What's the plan for other elements that might need to update based on RTL? ...
4 years, 10 months ago (2016-02-17 21:14:04 UTC) #7
Dan Beam
On 2016/02/17 21:14:04, michaelpg wrote: > lgtm > > What's the plan for other elements ...
4 years, 10 months ago (2016-02-18 00:16:15 UTC) #8
Dan Beam
https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/rtl_tests.js File chrome/test/data/webui/settings/rtl_tests.js (right): https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/rtl_tests.js#newcode17 chrome/test/data/webui/settings/rtl_tests.js:17: Polymer.dom.flush(); On 2016/02/18 00:16:15, Dan Beam wrote: > On ...
4 years, 10 months ago (2016-02-18 00:16:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700273003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700273003/80001
4 years, 10 months ago (2016-02-18 00:18:41 UTC) #12
michaelpg
slgtm https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/rtl_tests.js File chrome/test/data/webui/settings/rtl_tests.js (right): https://codereview.chromium.org/1700273003/diff/60001/chrome/test/data/webui/settings/rtl_tests.js#newcode17 chrome/test/data/webui/settings/rtl_tests.js:17: Polymer.dom.flush(); On 2016/02/18 00:16:45, Dan Beam wrote: > ...
4 years, 10 months ago (2016-02-18 00:23:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/175330) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 00:58:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700273003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700273003/80001
4 years, 10 months ago (2016-02-18 01:26:23 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-18 02:36:21 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:37:37 UTC) #20
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/98b969da7999ff1b3b25fb7ac295d9afcbff2d35
Cr-Commit-Position: refs/heads/master@{#376071}

Powered by Google App Engine
This is Rietveld 408576698