Clean up header includes in TextBreakIteratorICU.cpp

Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.

Committed: https://crrev.com/d10de664bfd398b9dbf4fdb690d1cff92c900011
Cr-Commit-Position: refs/heads/master@{#375733}

[rwlbuis, 2016-02-16 21:05:46]

Description was changed from

==========
Remove unneeded header files in TextBreakIteratorICU.cpp

BUG=
==========

to

==========
Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.
==========

[rwlbuis, 2016-02-16 21:34:42]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-02-16 21:34:42]

PTAL. Not super useful but done so we can close an old patch:
https://codereview.chromium.org/104603004/

[tkent, 2016-02-16 22:50:03]

Please follow the following paragraph of Google C++ style guide.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

You should include all the headers that define the symbols you rely upon, except
in the unusual case of forward declaration. If you rely on symbols from bar.h,
don't count on the fact that you included foo.h which (currently) includes
bar.h: include bar.h yourself, unless foo.h explicitly demonstrates its intent
to provide you the symbols of bar.h. However, any includes present in the
related header do not need to be included again in the related cc (i.e., foo.cc
can rely on foo.h's includes).

[rwlbuis, 2016-02-16 23:24:06]

On 2016/02/16 22:50:03, tkent wrote:
> Please follow the following paragraph of Google C++ style guide.
> 
> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
> 
> You should include all the headers that define the symbols you rely upon,
except
> in the unusual case of forward declaration. If you rely on symbols from bar.h,
> don't count on the fact that you included foo.h which (currently) includes
> bar.h: include bar.h yourself, unless foo.h explicitly demonstrates its intent
> to provide you the symbols of bar.h. However, any includes present in the
> related header do not need to be included again in the related cc (i.e.,
foo.cc
> can rely on foo.h's includes).

This is great to know, thanks!
With these new rules, I think the only two we can remove are CString.h and
AtomicString.h (already included in TextBreakIterator.h).

[tkent, 2016-02-16 23:34:50]

lgtm

[tkent, 2016-02-16 23:34:57]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:36:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1700213003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1700213003/40001

[commit-bot: I haz the power, 2016-02-17 00:55:40]

Description was changed from

==========
Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.
==========

to

==========
Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.
==========

[commit-bot: I haz the power, 2016-02-17 00:55:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 00:56:37]

Description was changed from

==========
Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.
==========

to

==========
Clean up header includes in TextBreakIteratorICU.cpp

Based on work by a.bah@samsung.com.

Committed: https://crrev.com/d10de664bfd398b9dbf4fdb690d1cff92c900011
Cr-Commit-Position: refs/heads/master@{#375733}
==========

[commit-bot: I haz the power, 2016-02-17 00:56:37]

Patchset 3 (id:??) landed as
https://crrev.com/d10de664bfd398b9dbf4fdb690d1cff92c900011
Cr-Commit-Position: refs/heads/master@{#375733}