Issue 104603004: Minor clean-up: Remove unneeded header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104603004: Minor clean-up: Remove unneeded header files. (Closed)

Created:
6 years, 12 months ago by arpitab_

Modified:
4 years, 10 months ago

Reviewers:
lgombos, eseidel

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Minor clean-up: Remove unneeded header files.

Patch Set 2 : Removing more unrequired header files #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	Source/platform/text/TextBreakIteratorICU.cpp	View	1	1 chunk	+0 lines, -5 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lgombos

Can you run the try bot to have some evidence that these headers are not ...

6 years, 6 months ago (2014-06-16 17:18:46 UTC) #3

lgombos

https://codereview.chromium.org/104603004/diff/60001/Source/platform/text/TextBreakIteratorICU.cpp File Source/platform/text/TextBreakIteratorICU.cpp (left): https://codereview.chromium.org/104603004/diff/60001/Source/platform/text/TextBreakIteratorICU.cpp#oldcode34 Source/platform/text/TextBreakIteratorICU.cpp:34: #include <unicode/ubrk.h> Is it is you need to include ...

6 years, 6 months ago (2014-06-16 18:40:29 UTC) #4

rwlbuis

4 years, 10 months ago (2016-02-16 21:35:28 UTC) #5

On 2014/06/16 18:40:29, lgombos wrote:
>
https://codereview.chromium.org/104603004/diff/60001/Source/platform/text/Tex...
> File Source/platform/text/TextBreakIteratorICU.cpp (left):
> 
>
https://codereview.chromium.org/104603004/diff/60001/Source/platform/text/Tex...
> Source/platform/text/TextBreakIteratorICU.cpp:34: #include <unicode/ubrk.h>
> Is it is you need to include ubrk.h to get the definition of UBRK_WORD_NONE.
> 
> It seems though that you can easily remove that dependency as it can be
assumed
> that UBRK_WORD_NONE is always 0.

Will close, continuing here:
https://codereview.chromium.org/1700213003/

Expand Messages | Collapse Messages

Issue 104603004: Minor clean-up: Remove unneeded header files. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removing more unrequired header files #

Messages