Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170013002: Removed unnecessary comparison checking bits in DEVMODE::dmFields. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Removed unnecessary comparison checking bits in DEVMODE::dmFields. DM_YRESOLUTION check was invalid. TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M printing/backend/print_backend_win.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-17 23:58:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/170013002/1
6 years, 10 months ago (2014-02-17 23:58:41 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 00:59:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265422
6 years, 10 months ago (2014-02-18 00:59:28 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-18 05:40:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/170013002/1
6 years, 10 months ago (2014-02-18 05:41:11 UTC) #6
commit-bot: I haz the power
Change committed as 251737
6 years, 10 months ago (2014-02-18 08:01:19 UTC) #7
Noam Samuel
6 years, 10 months ago (2014-02-18 18:51:22 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698