Removed unnecessary comparison checking bits in DEVMODE::dmFields.

printing/backend/print_backend_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/backend/print_backend.h"
 
 #include <objidl.h>
 #include <winspool.h>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 78 matching lines @@
       tmp_name = tmp_name.c_str();
       paper.name = base::WideToUTF8(tmp_name);
     }
     caps->papers.push_back(paper);
   }
 
   if (devmode) {
     short default_id = 0;
     gfx::Size default_size;
 
-    if ((devmode->dmFields & DM_PAPERSIZE) == DM_PAPERSIZE)
+    if (devmode->dmFields & DM_PAPERSIZE)
       default_id = devmode->dmPaperSize;
-    if ((devmode->dmFields & DM_PAPERWIDTH) == DM_PAPERWIDTH)
+    if (devmode->dmFields & DM_PAPERWIDTH)
       default_size.set_width(devmode->dmPaperWidth * kToUm);
-    if ((devmode->dmFields & DM_PAPERLENGTH) == DM_PAPERLENGTH)
+    if (devmode->dmFields & DM_PAPERLENGTH)
       default_size.set_height(devmode->dmPaperLength * kToUm);
 
     if (default_size.IsEmpty()) {
       for (size_t i = 0; i < ids.size(); ++i) {
         if (ids[i] == default_id) {
           PrinterSemanticCapsAndDefaults::Paper paper;
           paper.size_um.SetSize(sizes[i].x * kToUm, sizes[i].y * kToUm);
           if (!names.empty()) {
             const wchar_t* name_start = names[i].chars;
             base::string16 tmp_name(name_start, kMaxPaperName);
@@ skipping 15 matching lines @@
              const wchar_t* port,
              const DEVMODE* devmode,
              PrinterSemanticCapsAndDefaults* caps) {
   std::vector<POINT> dpis;
   GetDeviceCapabilityArray(printer, port, DC_ENUMRESOLUTIONS, &dpis);
 
   for (size_t i = 0; i < dpis.size() ; ++i)
     caps->dpis.push_back(gfx::Size(dpis[i].x, dpis[i].y));
 
   if (devmode) {
-    if ((devmode->dmFields & DM_PRINTQUALITY) == DM_PRINTQUALITY &&
-        devmode->dmPrintQuality > 0) {
+    if ((devmode->dmFields & DM_PRINTQUALITY) && devmode->dmPrintQuality > 0) {
       caps->default_dpi.SetSize(devmode->dmPrintQuality,
                                 devmode->dmPrintQuality);
-      if ((devmode->dmFields & DM_YRESOLUTION) == DM_PRINTQUALITY) {
+      if (devmode->dmFields & DM_YRESOLUTION) {
         caps->default_dpi.set_height(devmode->dmYResolution);
       }
     }
   }
 }
 
 }  // namespace
 
 class PrintBackendWin : public PrintBackend {
  public:
@@ skipping 68 matching lines @@
   PrinterInfo5 info_5;
   if (!info_5.Init(printer_handle))
     return false;
   const wchar_t* name = info_5.get()->pPrinterName;
   const wchar_t* port = info_5.get()->pPortName;
   DCHECK_EQ(name, base::UTF8ToUTF16(printer_name));
 
   PrinterSemanticCapsAndDefaults caps;
   UserDefaultDevMode user_settings;
   if (user_settings.Init(printer_handle)) {
-    if ((user_settings.get()->dmFields & DM_COLOR) == DM_COLOR)
+    if (user_settings.get()->dmFields & DM_COLOR)
       caps.color_default = (user_settings.get()->dmColor == DMCOLOR_COLOR);
 
-    if ((user_settings.get()->dmFields & DM_DUPLEX) == DM_DUPLEX) {
+    if (user_settings.get()->dmFields & DM_DUPLEX) {
       switch (user_settings.get()->dmDuplex) {
       case DMDUP_SIMPLEX:
         caps.duplex_default = SIMPLEX;
         break;
       case DMDUP_VERTICAL:
         caps.duplex_default = LONG_EDGE;
         break;
       case DMDUP_HORIZONTAL:
         caps.duplex_default = SHORT_EDGE;
         break;
       default:
         NOTREACHED();
       }
     }
 
-    if ((user_settings.get()->dmFields & DM_COLLATE) == DM_COLLATE)
+    if (user_settings.get()->dmFields & DM_COLLATE)
       caps.collate_default = (user_settings.get()->dmCollate == DMCOLLATE_TRUE);
   } else {
     LOG(WARNING) << "Fallback to color/simplex mode.";
     caps.color_default = caps.color_changeable;
     caps.duplex_default = SIMPLEX;
   }
 
   // Get printer capabilities. For more info see here:
   // http://msdn.microsoft.com/en-us/library/windows/desktop/dd183552(v=vs.85).aspx
   caps.color_changeable =
@@ skipping 92 matching lines @@
   ScopedPrinterHandle printer_handle;
   return printer_handle.OpenPrinter(base::UTF8ToWide(printer_name).c_str());
 }
 
 scoped_refptr<PrintBackend> PrintBackend::CreateInstance(
     const base::DictionaryValue* print_backend_settings) {
   return new PrintBackendWin;
 }
 
 }  // namespace printing