Issue 1700103002: VM: Move representation selection code out of the flow graph optimizer.

Issue 1700103002: VM: Move representation selection code out of the flow graph optimizer. (Closed)

Created:
4 years, 10 months ago by Florian Schneider

Modified:
4 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Move representation selection code out of the flow graph optimizer. I moved these functions to flow_graph.cc since these optimizations only need a FlowGraph as input, and they are shared between precompiler and compiler. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/3076bdf3215e33bb2c68ef21793f2d8937f3e453

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+644 lines, -610 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2	7 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph.h	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View		3 chunks	+567 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View		2 chunks	+0 lines, -21 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	5 chunks	+1 line, -563 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View		7 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 7 (3 generated)

Florian Schneider

4 years, 10 months ago (2016-02-18 15:37:45 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
3076bdf3215e33bb2c68ef21793f2d8937f3e453 (presubmit successful).