Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 1700103002: VM: Move representation selection code out of the flow graph optimizer. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove some dead code Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.h
diff --git a/runtime/vm/flow_graph_optimizer.h b/runtime/vm/flow_graph_optimizer.h
index 79abf12f1d6ffdbd59136180a467c220eb921b4f..311d3081c8e0efb8009fe04ef7b228ce5dd2234e 100644
--- a/runtime/vm/flow_graph_optimizer.h
+++ b/runtime/vm/flow_graph_optimizer.h
@@ -45,18 +45,6 @@ class FlowGraphOptimizer : public FlowGraphVisitor {
// Merge instructions (only per basic-block).
void TryOptimizePatterns();
- // Returns true if any instructions were canonicalized away.
- bool Canonicalize();
-
- void EliminateDeadPhis();
-
- void SelectRepresentations();
-
- void WidenSmiToInt32();
-
- // Remove environments from the instructions which do not deoptimize.
- void EliminateEnvironments();
-
virtual void VisitStaticCall(StaticCallInstr* instr);
virtual void VisitInstanceCall(InstanceCallInstr* instr);
virtual void VisitStoreInstanceField(StoreInstanceFieldInstr* instr);
@@ -138,15 +126,6 @@ class FlowGraphOptimizer : public FlowGraphVisitor {
void ReplaceCall(Definition* call, Definition* replacement);
- void InsertConversionsFor(Definition* def);
-
- void ConvertUse(Value* use, Representation from);
- void ConvertEnvironmentUse(Value* use, Representation from);
-
- void InsertConversion(Representation from,
- Representation to,
- Value* use,
- bool is_environment_use);
bool InstanceCallNeedsClassCheck(InstanceCallInstr* call,
RawFunction::Kind kind) const;
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698