Get rid of MetaTableHelper class and make use of the app/sql API in the LoginDatabase.

Get rid of MetaTableHelper class and make use of the app/sql API in the LoginDatabase.

BUG=None
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46929

[tfarina (gmail-do not use), 2010-05-03 02:38:01]

Hi Stuart, could you review this to me?

[stuartmorgan, 2010-05-03 20:32:31]

http://codereview.chromium.org/1700017/diff/8001/9009
File chrome/browser/password_manager/login_database.h (left):

http://codereview.chromium.org/1700017/diff/8001/9009#oldcode50
chrome/browser/password_manager/login_database.h:50:
std::vector<webkit_glue::PasswordForm*>* forms) const;
Maybe it would make more sense to make db_ mutable than to remove const from all
the methods?

[tfarina (gmail-do not use), 2010-05-04 02:18:56]

Hi Stuart, could you take another look?


On 2010/05/03 20:32:31, stuartmorgan wrote:
> http://codereview.chromium.org/1700017/diff/8001/9009
> File chrome/browser/password_manager/login_database.h (left):
> 
> http://codereview.chromium.org/1700017/diff/8001/9009#oldcode50
> chrome/browser/password_manager/login_database.h:50:
> std::vector<webkit_glue::PasswordForm*>* forms) const;
> Maybe it would make more sense to make db_ mutable than to remove const from
all
> the methods?

Totally, thanks for the suggestion. Fixed!

[stuartmorgan, 2010-05-04 18:25:51]

LGTM

[tfarina (gmail-do not use), 2010-05-06 04:05:34]

Stuart, could you land this to me?

[stuartmorgan, 2010-05-07 17:03:18]

This patch failed the PasswordStore tests on all three platforms when I ran it
through the try bots. Did you run those tests locally?

[tfarina (gmail-do not use), 2010-05-08 14:10:28]

On 2010/05/07 17:03:18, stuartmorgan wrote:
> This patch failed the PasswordStore tests on all three platforms when I ran it
> through the try bots. Did you run those tests locally?

Stuart, please take another look. I did the necessary changes. I also ran
through the trybots and everything now is green.

[tfarina (gmail-do not use), 2010-05-11 17:04:27]

Ping!

[stuartmorgan, 2010-05-11 17:11:09]

Whoops, I thought I landed this yesterday. Sorry about that :(

LGTM