Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/password_manager/login_database.h

Issue 1700017: Get rid of MetaTableHelper class and make use of the app/sql API in the LoginDatabase. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: fix rebase that removed the chrome_tests.gypi Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/meta_table_helper_unittest.cc ('k') | chrome/browser/password_manager/login_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/login_database.h
diff --git a/chrome/browser/password_manager/login_database.h b/chrome/browser/password_manager/login_database.h
index 8fc9694176f8d0f38faf24b61d8f92f072d57390..913fc1700e9e2a7ddfbec895efa3a6ab0ba050b0 100644
--- a/chrome/browser/password_manager/login_database.h
+++ b/chrome/browser/password_manager/login_database.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -8,8 +8,9 @@
#include <string>
#include <vector>
+#include "app/sql/connection.h"
+#include "app/sql/meta_table.h"
#include "base/string16.h"
-#include "chrome/browser/meta_table_helper.h"
#include "webkit/glue/password_form.h"
class FilePath;
@@ -63,8 +64,7 @@ class LoginDatabase {
std::vector<webkit_glue::PasswordForm*>* forms) const;
// Loads the complete list of blacklist forms into |forms|.
- bool GetBlacklistLogins(
- std::vector<webkit_glue::PasswordForm*>* forms) const;
+ bool GetBlacklistLogins(std::vector<webkit_glue::PasswordForm*>* forms) const;
private:
// Returns an encrypted version of plain_text.
@@ -79,15 +79,15 @@ class LoginDatabase {
// Fills |form| from the values in the given statement (which is assumed to
// be of the form used by the Get*Logins methods).
void InitPasswordFormFromStatement(webkit_glue::PasswordForm* form,
- SQLStatement* s) const;
+ sql::Statement& s) const;
// Loads all logins whose blacklist setting matches |blacklisted| into
// |forms|.
bool GetAllLoginsWithBlacklistSetting(
bool blacklisted, std::vector<webkit_glue::PasswordForm*>* forms) const;
- sqlite3* db_;
- MetaTableHelper meta_table_;
+ mutable sql::Connection db_;
+ sql::MetaTable meta_table_;
DISALLOW_COPY_AND_ASSIGN(LoginDatabase);
};
« no previous file with comments | « chrome/browser/meta_table_helper_unittest.cc ('k') | chrome/browser/password_manager/login_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698