third_party/WebKit/Source/bindings/core/v8/V8Binding.h - Issue 1699983002: Editing: Make |EditingState*| arguments of CompositeEditCommand::moveParagraph* mandatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 1699983002: Editing: Make |EditingState*| arguments of CompositeEditCommand::moveParagraph* mandatory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

index 46bd284a93ffecd896ef88ca23d472d1f655f835..e9477c9dd0bc2e22a983c43d6f71074f412eafc3 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

@@ -438,7 +438,7 @@ inline v8::Local<v8::String> v8AtomicString(v8::Isolate* isolate, const char* st

return value;

// Immediately crashes when NewFromUtf8() fails because it only fails the

// given str is too long.

- RELEASE_ASSERT_NOT_REACHED();

+ RELEASE_NOTREACHED();

return v8::String::Empty(isolate);

}

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ToV8.h ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »