Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html

Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html
diff --git a/third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html b/third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html
new file mode 100644
index 0000000000000000000000000000000000000000..8266ea341ab5ca5d8f4c1cc4bdda791f0ef67739
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<svg width="1" height="1" visibility="hidden">
fs 2016/02/19 10:33:13 Specifying 'visibility' here is pretty unnecessary
Shanmuga Pandi 2016/02/22 06:45:07 Acknowledged.
+ <marker markerWidth="1" markerHeight="1">
fs 2016/02/19 10:33:13 None of this should be needed - and it's probably
Shanmuga Pandi 2016/02/22 06:45:07 Done.
+ </marker>
+</svg>
+<script>
+var svgElement = document.querySelector("svg");
+var markerElement = document.querySelector("marker");
+
+test(function() {
+ markerElement.setAttribute("orient", "1");
+ assert_equals(markerElement.getAttribute("orient"), "1");
+}, "Tests with setAttribute");
fs 2016/02/19 10:33:12 This test seems pretty redundant in the context of
Shanmuga Pandi 2016/02/22 06:45:07 Acknowledged.
+
+test(function() {
+ var svgAngle = svgElement.createSVGAngle();
+ svgAngle.value = 10;
+ markerElement.setOrientToAngle(svgAngle);
fs 2016/02/19 10:33:13 These tests are dependent on the result of the pre
Shanmuga Pandi 2016/02/22 06:45:07 Done.
+ assert_equals(markerElement.getAttribute("orient"), "10");
+}, "Tests with setOrientToAngle");
+
+test(function() {
+ markerElement.setOrientToAuto();
+ assert_equals(markerElement.getAttribute("orient"), "auto");
+}, "Tests with setOrientToAuto");
+</script>

Powered by Google App Engine
This is Rietveld 408576698