third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html - Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute

Side by Side Diff: third_party/WebKit/LayoutTests/svg/markers/marker-orientation-set.html

Issue 1699893003: setOrientTo{Auto|Angle} should reflect on orient attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg width="1" height="1" visibility="hidden">
	fs 2016/02/19 10:33:13 Specifying 'visibility' here is pretty unnecessary Specifying 'visibility' here is pretty unnecessary because there is nothing in the <svg> fragment that will render anyway. Also, 'height' (or 'width') can just be set to zero - the only real use of this fragment is to have a SVGSVGElement anyway (which could be achieved without one in the document as well.) Shanmuga Pandi 2016/02/22 06:45:07 Acknowledged. Show quoted text On 2016/02/19 10:33:13, fs wrote: > Specifying 'visibility' here is pretty unnecessary because there is nothing in > the <svg> fragment that will render anyway. Also, 'height' (or 'width') can just > be set to zero - the only real use of this fragment is to have a SVGSVGElement > anyway (which could be achieved without one in the document as well.) Acknowledged.
	5 <marker markerWidth="1" markerHeight="1">
	fs 2016/02/19 10:33:13 None of this should be needed - and it's probably None of this should be needed - and it's probably even preferable not to have it - see below. Shanmuga Pandi 2016/02/22 06:45:07 Done. Show quoted text On 2016/02/19 10:33:13, fs wrote: > None of this should be needed - and it's probably even preferable not to have it > - see below. Done.
	6 </marker>

	7 </svg>

	8 <script>

	9 var svgElement = document.querySelector("svg");

	10 var markerElement = document.querySelector("marker");

	11

	12 test(function() {

	13 markerElement.setAttribute("orient", "1");

	14 assert_equals(markerElement.getAttribute("orient"), "1");

	15 }, "Tests with setAttribute");
	fs 2016/02/19 10:33:12 This test seems pretty redundant in the context of This test seems pretty redundant in the context of what we're testing. (Testing that setAttribute works is likely covered already.) Shanmuga Pandi 2016/02/22 06:45:07 Acknowledged. Show quoted text On 2016/02/19 10:33:12, fs wrote: > This test seems pretty redundant in the context of what we're testing. (Testing > that setAttribute works is likely covered already.) Acknowledged.
	16

	17 test(function() {

	18 var svgAngle = svgElement.createSVGAngle();

	19 svgAngle.value = 10;

	20 markerElement.setOrientToAngle(svgAngle);
	fs 2016/02/19 10:33:13 These tests are dependent on the result of the pre These tests are dependent on the result of the previous test (and without verifying that the element is in an expected state.) I think it'd be better to have each subtest create a new <marker> element and test what it likes on that one. (That'd likely expose one issue with the fix in it's current form.) Shanmuga Pandi 2016/02/22 06:45:07 Done. Show quoted text On 2016/02/19 10:33:13, fs wrote: > These tests are dependent on the result of the previous test (and without > verifying that the element is in an expected state.) I think it'd be better to > have each subtest create a new <marker> element and test what it likes on that > one. (That'd likely expose one issue with the fix in it's current form.) Done.
	21 assert_equals(markerElement.getAttribute("orient"), "10");

	22 }, "Tests with setOrientToAngle");

	23

	24 test(function() {

	25 markerElement.setOrientToAuto();

	26 assert_equals(markerElement.getAttribute("orient"), "auto");

	27 }, "Tests with setOrientToAuto");

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp » ('J')