Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1699763002: [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (Closed)

Created:
4 years, 10 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, rouslan+autofill_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Enable AutoResize for Constrained Web Dialogs for Mac. Currently only constrained web dialogs for views (Linux/Windows) are able to autoresize. This change implements the option to pass in minimum and maximum sizes and enabling autoresizing functionality for OSX. This change adds two static functions for options on whether to create a ConstrainedWindowsMac that autoresizes or is of fixed size. The first two patches were reverted because of flaky tests on Mac 10.9. Those patches can be found at: 1. https://codereview.chromium.org/1430023002 2. https://codereview.chromium.org/1446623003 After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585. The patch to disable occlusion notifications can be found at: https://codereview.chromium.org/1762883002/ BUG=217034 Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de Cr-Commit-Position: refs/heads/master@{#379512}

Patch Set 1 : cl 1446623003 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -87 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 7 chunks +139 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h View 4 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +42 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 6 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 7 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
apacible
The CL to disabling occlusion notifications has landed. PTAL, thanks!
4 years, 9 months ago (2016-03-07 02:30:37 UTC) #7
Nico
rs-lgtm; assuming this is to what landed before
4 years, 9 months ago (2016-03-07 03:14:11 UTC) #8
apacible
Thanks! Yes, this is the same as what landed previously.
4 years, 9 months ago (2016-03-07 03:31:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699763002/60001
4 years, 9 months ago (2016-03-07 03:31:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 9 months ago (2016-03-07 04:40:47 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de Cr-Commit-Position: refs/heads/master@{#379512}
4 years, 9 months ago (2016-03-07 04:41:59 UTC) #15
apacible
4 years, 9 months ago (2016-03-08 06:57:35 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/1778453002/ by apacible@chromium.org.

The reason for reverting is: This change breaks Print Preview. See
crbug/592878..

Powered by Google App Engine
This is Rietveld 408576698