|
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.
Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.
This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.
The first two patches were reverted because of flaky tests on Mac 10.9.
Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003
After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585.
The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/
BUG= 217034
Committed: https://crrev.com/0f9cb2c0e411b4af936efc54f457aa000e3292de
Cr-Commit-Position: refs/heads/master@{#379512}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+319 lines, -87 lines) |
Patch |
 |
M |
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/certificate_viewer_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/certificate_viewer_mac.mm
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm
|
View
|
|
7 chunks |
+139 lines, -18 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h
|
View
|
|
4 chunks |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm
|
View
|
|
2 chunks |
+42 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
|
View
|
|
6 chunks |
+16 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/device_permissions_dialog_controller.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/login_prompt_cocoa.mm
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/profiles/user_manager_mac.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm
|
View
|
|
1 chunk |
+5 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/constrained_web_dialog_ui.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc
|
View
|
|
7 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
Total messages: 16 (9 generated)
|