chrome/browser/ui/cocoa/login_prompt_cocoa.mm - Issue 1699763002: [Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

Issue 1699763002: [Reland] Enable AutoResize for Constrained Web Dialogs for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_dialog_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/login_prompt_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

index 2c24253b334721bc3a2796c18c224ea5a2dd3e6e..4d7278255c858cae23fa9a78dc1f53d7781d9ee2 100644

--- a/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

+++ b/chrome/browser/ui/cocoa/login_prompt_cocoa.mm

@@ -80,8 +80,8 @@ class LoginHandlerMac : public LoginHandler,

base::scoped_nsobject<CustomConstrainedWindowSheet> sheet(

[[CustomConstrainedWindowSheet alloc]

initWithCustomWindow:[sheet_controller_ window]]);

- constrained_window_.reset(new ConstrainedWindowMac(

- this, requesting_contents, sheet));

+ constrained_window_ = CreateAndShowWebModalDialogMac(

+ this, requesting_contents, sheet);

NotifyAuthNeeded();

}

@@ -126,7 +126,7 @@ class LoginHandlerMac : public LoginHandler,

// The Cocoa controller of the GUI.

base::scoped_nsobject<LoginHandlerSheet> sheet_controller_;

- scoped_ptr<ConstrainedWindowMac> constrained_window_;

+ std::unique_ptr<ConstrainedWindowMac> constrained_window_;

DISALLOW_COPY_AND_ASSIGN(LoginHandlerMac);

};