Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1699713002: Fix "undefined reference to '__atomic_is_lock_free'" errors on Linux (Closed)

Created:
3 years, 10 months ago by Adam Goode
Modified:
3 years, 10 months ago
Reviewers:
bcwhite, Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "undefined reference to '__atomic_is_lock_free'" errors on Linux BUG=546019 Committed: https://crrev.com/f3f51116a0689b6878fc66d5763bd93d494f9f36 Cr-Commit-Position: refs/heads/master@{#375507}

Patch Set 1 #

Patch Set 2 : Fix use_sysroot=1 #

Patch Set 3 : fix use_sysroot include #

Patch Set 4 : fix use_sysroot for gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M base/BUILD.gn View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M base/base.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Adam Goode
3 years, 10 months ago (2016-02-15 16:14:05 UTC) #3
bcwhite
lgtm
3 years, 10 months ago (2016-02-15 19:28:40 UTC) #4
Adam Goode
3 years, 10 months ago (2016-02-15 21:11:43 UTC) #6
Nico
lgtm, thanks!
3 years, 10 months ago (2016-02-15 21:34:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699713002/60001
3 years, 10 months ago (2016-02-15 22:52:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/23478)
3 years, 10 months ago (2016-02-16 01:03:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699713002/60001
3 years, 10 months ago (2016-02-16 01:33:54 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 10 months ago (2016-02-16 02:50:43 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2016-02-16 22:51:12 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f3f51116a0689b6878fc66d5763bd93d494f9f36
Cr-Commit-Position: refs/heads/master@{#375507}

Powered by Google App Engine
This is Rietveld 408576698