Rework progressive render loop.

Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e6a5138ec89a1235bf426fd19a0e4f61dfeafca0

[Tom Sepez, 2016-02-12 20:14:05]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.
==========

[Tom Sepez, 2016-02-12 20:14:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-12 20:19:20]

https://codereview.chromium.org/1699443002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (left):

https://codereview.chromium.org/1699443002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1069: if (LastPos == m_PrevLastPos)
{
We now use the notion of a "current layer" rather than prev last pos to tell if
we had a current layer.  This is the main fix.

https://codereview.chromium.org/1699443002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1078: if (LastPos == m_PrevLastPos)
{
This cleanup falls down to below and merges with block at old 1150.

https://codereview.chromium.org/1699443002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1699443002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1062: int objs_to_go = step_limit;
Change in behaviour here, we check for limit every N objs, not every N objs
within a single layer, reseting at layer boundaries ...

[Tom Sepez, 2016-02-12 21:00:36]

hang on ... this still isn't right ... needs to render any available object
before checking if the thing is fully parsed.

[Tom Sepez, 2016-02-12 22:53:15]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new objects
have been added to a layer.  The old code used to do this by keeping track of
the last element in the list, and seeing if it changes. It's far simpler to keep
track of the last element processed, and just keep looking for more objects
after it.
==========

[Tom Sepez, 2016-02-12 22:54:03]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new objects
have been added to a layer.  The old code used to do this by keeping track of
the last element in the list, and seeing if it changes. It's far simpler to keep
track of the last element processed, and just keep looking for more objects
after it.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new objects
have been added to a layer.  The old code used to do this by
keeping track of the last element in the list, and seeing if
it changes. It's far simpler to keep track of the last
element processed, and just keep looking for more objects
after it with each pass.

Fold together some duplicated blocks along the way.
==========

[Tom Sepez, 2016-02-12 22:55:51]

Lei, for review (sorry in advance).

[Tom Sepez, 2016-02-12 23:06:37]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new objects
have been added to a layer.  The old code used to do this by
keeping track of the last element in the list, and seeing if
it changes. It's far simpler to keep track of the last
element processed, and just keep looking for more objects
after it with each pass.

Fold together some duplicated blocks along the way.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
==========

[Tom Sepez, 2016-02-13 00:09:26]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
==========

[Lei Zhang, 2016-02-13 01:08:12]

lgtm

https://codereview.chromium.org/1699443002/diff/80001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):

https://codereview.chromium.org/1699443002/diff/80001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1232:
CPDF_RenderConfig::CPDF_RenderConfig() {
Can we kill this class and make the two limits constants?

[Tom Sepez, 2016-02-16 17:16:31]

On 2016/02/13 01:08:12, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/1699443002/diff/80001/core/src/fpdfapi/fpdf_r...
> File core/src/fpdfapi/fpdf_render/fpdf_render.cpp (right):
> 
>
https://codereview.chromium.org/1699443002/diff/80001/core/src/fpdfapi/fpdf_r...
> core/src/fpdfapi/fpdf_render/fpdf_render.cpp:1232:
> CPDF_RenderConfig::CPDF_RenderConfig() {
> Can we kill this class and make the two limits constants?
Yes, and only one is used as it turns out.

[Tom Sepez, 2016-02-16 17:17:47]

Description was changed from

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
==========

to

==========
Rework progressive render loop.

Migrating this off of CFX_PrtList depends on first making
this saner.  The tricky part is checking whether new
objects have been added to a partially-parsed layer.  The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.

Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/e6a5138ec89a1235bf426fd19a0e4f61dfea...
==========

[Tom Sepez, 2016-02-16 17:17:49]

Committed patchset #7 (id:120001) manually as
e6a5138ec89a1235bf426fd19a0e4f61dfeafca0 (presubmit successful).