Rework progressive render loop.

core/src/fpdfapi/fpdf_render/fpdf_render.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
-#include "render_int.h"
+#include "core/src/fpdfapi/fpdf_render/render_int.h"
 
 #include "core/include/fpdfapi/fpdf_module.h"
 #include "core/include/fpdfapi/fpdf_render.h"
 #include "core/include/fxge/fx_ge.h"
 #include "core/src/fpdfapi/fpdf_page/pageint.h"
 
 CPDF_DocRenderData::CPDF_DocRenderData(CPDF_Document* pPDFDoc)
     : m_pPDFDoc(pPDFDoc), m_pFontCache(new CFX_FontCache) {}
 
 CPDF_DocRenderData::~CPDF_DocRenderData() {
@@ skipping 1014 matching lines @@
 CPDF_ProgressiveRenderer::CPDF_ProgressiveRenderer(
     CPDF_RenderContext* pContext,
     CFX_RenderDevice* pDevice,
     const CPDF_RenderOptions* pOptions)
     : m_Status(Ready),
       m_pContext(pContext),
       m_pDevice(pDevice),
       m_pOptions(pOptions),
       m_LayerIndex(0),
       m_ObjectIndex(0),
-      m_ObjectPos(nullptr),
-      m_PrevLastPos(nullptr) {
-}
+      m_pCurrentLayer(nullptr),
+      m_ObjectPos(nullptr) {}
 
 CPDF_ProgressiveRenderer::~CPDF_ProgressiveRenderer() {
   if (m_pRenderStatus)
     m_pDevice->RestoreState();
 }
 
 void CPDF_ProgressiveRenderer::Start(IFX_Pause* pPause) {
   if (!m_pContext || !m_pDevice || m_Status != Ready) {
     m_Status = Failed;
     return;
   }
   m_Status = ToBeContinued;
   Continue(pPause);
 }
 
 void CPDF_ProgressiveRenderer::Continue(IFX_Pause* pPause) {
-  if (m_Status != ToBeContinued) {
-    return;
-  }
-  FX_DWORD nLayers = m_pContext->CountLayers();
-  for (; m_LayerIndex < nLayers; m_LayerIndex++) {
-    CPDF_RenderContext::Layer* pLayer = m_pContext->GetLayer(m_LayerIndex);
-    FX_POSITION LastPos = pLayer->m_pObjectList->GetLastObjectPosition();
-    if (!m_ObjectPos) {
-      if (LastPos == m_PrevLastPos) {

[Tom Sepez, 2016/02/12 20:19:20]

We now use the notion of a "current layer" rather than prev last pos to tell if
we had a current layer.  This is the main fix.

-        if (!pLayer->m_pObjectList->IsParsed()) {
-          pLayer->m_pObjectList->ContinueParse(pPause);
-          if (!pLayer->m_pObjectList->IsParsed()) {
-            return;
-          }
-          LastPos = pLayer->m_pObjectList->GetLastObjectPosition();
-        }
+  int step_limit =
+      CPDF_ModuleMgr::Get()->GetRenderModule()->GetConfig()->m_RenderStepLimit;
+  int objs_to_go = step_limit;

[Tom Sepez, 2016/02/12 20:19:20]

Change in behaviour here, we check for limit every N objs, not every N objs
within a single layer, reseting at layer boundaries ...

+  while (m_Status == ToBeContinued) {
+    if (!m_pCurrentLayer) {
+      if (m_LayerIndex >= m_pContext->CountLayers()) {
+        m_Status = Done;
+        return;
       }
-      if (LastPos == m_PrevLastPos) {

[Tom Sepez, 2016/02/12 20:19:20]

This cleanup falls down to below and merges with block at old 1150.

-        if (m_pRenderStatus) {
-          m_pRenderStatus.reset();
-          m_pDevice->RestoreState();
-          m_ObjectPos = NULL;
-          m_PrevLastPos = NULL;
-        }
-        continue;
+      CPDF_RenderContext::Layer* pLayer = m_pContext->GetLayer(m_LayerIndex);
+      if (!pLayer->m_pObjectList->IsParsed()) {
+        pLayer->m_pObjectList->ContinueParse(pPause);
+        if (!pLayer->m_pObjectList->IsParsed())
+          return;
       }
-      if (m_PrevLastPos) {
-        m_ObjectPos = m_PrevLastPos;
-        pLayer->m_pObjectList->GetNextObject(m_ObjectPos);
-      } else {
-        m_ObjectPos = pLayer->m_pObjectList->GetFirstObjectPosition();
-      }
-      m_PrevLastPos = LastPos;
-    }
-    if (!m_pRenderStatus) {
+      m_pCurrentLayer = pLayer;
       m_ObjectPos = pLayer->m_pObjectList->GetFirstObjectPosition();
       m_ObjectIndex = 0;
       m_pRenderStatus.reset(new CPDF_RenderStatus());
       m_pRenderStatus->Initialize(
           m_pContext, m_pDevice, NULL, NULL, NULL, NULL, m_pOptions,
           pLayer->m_pObjectList->m_Transparency, FALSE, NULL);
       m_pDevice->SaveState();
       m_ClipRect = m_pDevice->GetClipBox();
       CFX_Matrix device2object;
       device2object.SetReverse(pLayer->m_Matrix);
       device2object.TransformRect(m_ClipRect);
     }
-    int objs_to_go = CPDF_ModuleMgr::Get()
-                         ->GetRenderModule()
-                         ->GetConfig()
-                         ->m_RenderStepLimit;
     while (m_ObjectPos) {
       CPDF_PageObject* pCurObj =
-          pLayer->m_pObjectList->GetObjectAt(m_ObjectPos);
+          m_pCurrentLayer->m_pObjectList->GetObjectAt(m_ObjectPos);
       if (pCurObj && pCurObj->m_Left <= m_ClipRect.right &&
           pCurObj->m_Right >= m_ClipRect.left &&
           pCurObj->m_Bottom <= m_ClipRect.top &&
           pCurObj->m_Top >= m_ClipRect.bottom) {
-        if (m_pRenderStatus->ContinueSingleObject(pCurObj, &pLayer->m_Matrix,
-                                                  pPause)) {
+        if (m_pRenderStatus->ContinueSingleObject(
+                pCurObj, &m_pCurrentLayer->m_Matrix, pPause)) {
           return;
         }
         if (pCurObj->m_Type == CPDF_PageObject::IMAGE &&
             m_pRenderStatus->m_Options.m_Flags & RENDER_LIMITEDIMAGECACHE) {
           m_pContext->GetPageCache()->CacheOptimization(
               m_pRenderStatus->m_Options.m_dwLimitCacheSize);
         }
+        m_ObjectIndex++;
+        m_pCurrentLayer->m_pObjectList->GetNextObject(m_ObjectPos);
         if (pCurObj->m_Type == CPDF_PageObject::FORM ||
-            pCurObj->m_Type == CPDF_PageObject::SHADING) {
-          objs_to_go = 0;
-        } else {
-          objs_to_go--;
+            pCurObj->m_Type == CPDF_PageObject::SHADING || --objs_to_go == 0) {
+          if (pPause && pPause->NeedToPauseNow()) {
+            return;
+          }
+          objs_to_go = step_limit;
         }
       }
-      m_ObjectIndex++;
-      pLayer->m_pObjectList->GetNextObject(m_ObjectPos);
-      if (objs_to_go == 0) {
-        if (pPause && pPause->NeedToPauseNow()) {
-          return;
-        }
-        objs_to_go = CPDF_ModuleMgr::Get()
-                         ->GetRenderModule()
-                         ->GetConfig()
-                         ->m_RenderStepLimit;
-      }
-    }
-    if (!pLayer->m_pObjectList->IsParsed()) {
-      return;
     }
     m_pRenderStatus.reset();
     m_pDevice->RestoreState();
     m_ObjectPos = NULL;
-    m_PrevLastPos = NULL;
-    if (pPause && pPause->NeedToPauseNow()) {
-      m_LayerIndex++;
-      return;
-    }
+    m_pCurrentLayer = nullptr;
+    m_LayerIndex++;
   }
-  m_Status = Done;
 }
+
 int CPDF_ProgressiveRenderer::EstimateProgress() {
   if (!m_pContext) {
     return 0;
   }
   FX_DWORD nLayers = m_pContext->CountLayers();
   int nTotal = 0;
   int nRendered = 0;
   for (FX_DWORD layer = 0; layer < nLayers; layer++) {
     CPDF_RenderContext::Layer* pLayer = m_pContext->GetLayer(layer);
     int nObjs = pLayer->m_pObjectList->CountObjects();
@@ skipping 227 matching lines @@
         item.GetParamType() == CPDF_ContentMarkItem::PropertiesDict) {
       CPDF_Dictionary* pOCG =
           ToDictionary(static_cast<CPDF_Object*>(item.GetParam()));
       if (!CheckOCGVisible(pOCG)) {
         return FALSE;
       }
     }
   }
   return TRUE;
 }