Fix regexp in roll_dep.py.

Fix regexp in roll_dep.py.

The fallback code was parsing DEPS entries improperly.

BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298839

[rohitrao (ping after 24h), 2016-02-17 01:10:15]

rohitrao@chromium.org changed reviewers:
+ smut@google.com

[smut, 2016-02-17 22:14:53]

Seems fine but I don't think I'm a depot_tools OWNER.

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py#newcode98
roll_dep.py:98: m = re.match(r'\s+"' + key + '":.*"([a-z0-9]{40})",', i)
Does it actually need to be .*? Not \s+ or something?

[rohitrao (ping after 24h), 2016-02-17 22:43:02]

rohitrao@chromium.org changed reviewers:
+ iannucci@chromium.org

[rohitrao (ping after 24h), 2016-02-17 22:43:02]

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py#newcode98
roll_dep.py:98: m = re.match(r'\s+"' + key + '":.*"([a-z0-9]{40})",', i)
On 2016/02/17 22:14:53, smut wrote:
> Does it actually need to be .*? Not \s+ or something?

The text in this region tends to be of the form:
"https://server/path" + "@" +

But I don't think it's always of that specific form.  I think we only really
care that the line starts with the key and ends with a git hash, and we don't
care so much about the specific format of what's in the middle.

[smut, 2016-02-17 22:43:59]

lgtm

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/1699333002/diff/1/roll_dep.py#newcode98
roll_dep.py:98: m = re.match(r'\s+"' + key + '":.*"([a-z0-9]{40})",', i)
On 2016/02/17 22:43:02, rohitrao wrote:
> On 2016/02/17 22:14:53, smut wrote:
> > Does it actually need to be .*? Not \s+ or something?
> 
> The text in this region tends to be of the form:
> "https://server/path" + "@" +
> 
> But I don't think it's always of that specific form.  I think we only really
> care that the line starts with the key and ends with a git hash, and we don't
> care so much about the specific format of what's in the middle.

Fair.

[rohitrao (ping after 24h), 2016-02-17 23:51:52]

+iannucci for OWNERS.

Is there a CQ for depot_tools?

[Dirk Pranke, 2016-02-18 00:02:15]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-02-18 00:02:15]

lgtm (as owner).

yes, there is a CQ.

[rohitrao (ping after 24h), 2016-02-18 00:02:50]

Thank you for the review!

[rohitrao (ping after 24h), 2016-02-18 00:03:05]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2016-02-18 00:03:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699333002/1

[commit-bot: I haz the power, 2016-02-18 00:05:22]

Description was changed from

==========
Fix regexp in roll_dep.py.

The fallback code was parsing DEPS entries improperly.

BUG=None
==========

to

==========
Fix regexp in roll_dep.py.

The fallback code was parsing DEPS entries improperly.

BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298839
==========

[commit-bot: I haz the power, 2016-02-18 00:05:23]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298839