Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: roll_dep.py

Issue 1699333002: Fix regexp in roll_dep.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: roll_dep.py
diff --git a/roll_dep.py b/roll_dep.py
index e40f55d4fa25a9865a97c5fada634ec375575f73..f6db7971d2688a284fe91372907d5bb6ff55f8bd 100755
--- a/roll_dep.py
+++ b/roll_dep.py
@@ -95,7 +95,7 @@ def roll(root, deps_dir, roll_to, key, reviewers, bug, no_log, log_limit,
# It happens if the user checked out a branch in the dependency by himself.
# Fall back to reading the DEPS to figure out the original commit.
for i in deps_content.splitlines():
- m = re.match(r'\s+"' + key + '": "([a-z0-9]{40})",', i)
+ m = re.match(r'\s+"' + key + '":.*"([a-z0-9]{40})",', i)
smut 2016/02/17 22:14:53 Does it actually need to be .*? Not \s+ or somethi
rohitrao (ping after 24h) 2016/02/17 22:43:02 The text in this region tends to be of the form: "
smut 2016/02/17 22:43:59 Fair.
if m:
head = m.group(1)
break
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698