Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1699173003: [Atomics] Add dmb/dsb/isb instructions to ARM (Closed)

Created:
4 years, 10 months ago by binji
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
http://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Add dmb/dsb/isb instructions to ARM This is not currently implemented in the simulator, just the assembler and disassembler. BUG=v8:4614 LOG=y Committed: https://crrev.com/2869071588c65d4527ff54a9d772125f27d3b1a6 Cr-Commit-Position: refs/heads/master@{#34093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -0 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
binji
I separated this out from https://codereview.chromium.org/1617503003/, PTAL.
4 years, 10 months ago (2016-02-17 00:16:42 UTC) #2
Jarin
lgtm, thanks!
4 years, 10 months ago (2016-02-17 07:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699173003/1
4 years, 10 months ago (2016-02-17 18:28:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11136)
4 years, 10 months ago (2016-02-17 18:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699173003/1
4 years, 10 months ago (2016-02-17 19:54:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 19:57:25 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 19:58:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2869071588c65d4527ff54a9d772125f27d3b1a6
Cr-Commit-Position: refs/heads/master@{#34093}

Powered by Google App Engine
This is Rietveld 408576698