Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699133002: [intrinsics] Remove the %_IsDate intrinsic. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@BooleanConstructor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove the %_IsDate intrinsic. It's fine to only have the runtime call here, as it's only used in the debug mirror. R=jarin@chromium.org Committed: https://crrev.com/0d595bb0016e7106b024ad2e975be78c7a90adb0 Cr-Commit-Position: refs/heads/master@{#34056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -200 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Depends on Patchset:

Issue 1698343002 Patch 20001

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-16 13:48:38 UTC) #1
Jarin
lgtm
4 years, 10 months ago (2016-02-17 07:25:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699133002/1
4 years, 10 months ago (2016-02-17 07:25:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 07:26:49 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 07:27:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d595bb0016e7106b024ad2e975be78c7a90adb0
Cr-Commit-Position: refs/heads/master@{#34056}

Powered by Google App Engine
This is Rietveld 408576698