Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1698343002: [builtins] Move the Boolean constructor to C++. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move the Boolean constructor to C++. Drive-by-fix: Remove the (now) unused %_SetValueOf and %_JSValueGetValue intrinsics from the various compilers and the runtime. R=jarin@chromium.org Committed: https://crrev.com/8f87c0acb7f241654cac9574b7ec61ef83a428da Cr-Commit-Position: refs/heads/master@{#34037}

Patch Set 1 #

Patch Set 2 : Also remove it from ia32 of course. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -397 lines) Patch
M src/bootstrapper.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/builtins.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/regress/setvalueof-deopt.js View 1 chunk +0 lines, -42 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-16 13:22:57 UTC) #1
Benedikt Meurer
Hey Jaro, Some code cleanup to reduce useless intrinsics. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-16 13:23:32 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-16 13:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698343002/20001
4 years, 10 months ago (2016-02-16 13:32:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 14:03:04 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 14:03:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f87c0acb7f241654cac9574b7ec61ef83a428da
Cr-Commit-Position: refs/heads/master@{#34037}

Powered by Google App Engine
This is Rietveld 408576698