Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1699123002: Unify BindState refcount management into the bound arguments. (Closed)

Created:
4 years, 10 months ago by tzik
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify BindState refcount management into the bound arguments. * Introduce MakeArgsStorage to adjust bound args type for the internal storage. * Remove MaybeScopedRefPtr. * Move std::decay from base::Bind to BindState. BUG=554299 Committed: https://crrev.com/c5849de5f84ff7fc49d9fefe51021f0a873f6193 Cr-Commit-Position: refs/heads/master@{#375718}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : +comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -51 lines) Patch
M base/bind.h View 2 chunks +2 lines, -3 lines 0 comments Download
M base/bind_helpers.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
M base/bind_internal.h View 1 2 3 chunks +22 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699123002/1
4 years, 10 months ago (2016-02-16 13:17:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 14:51:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699123002/20001
4 years, 10 months ago (2016-02-16 15:15:35 UTC) #7
tzik
PTAL
4 years, 10 months ago (2016-02-16 15:30:29 UTC) #10
Nico
lgtm
4 years, 10 months ago (2016-02-16 15:35:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699123002/40001
4 years, 10 months ago (2016-02-16 21:38:01 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-17 00:15:00 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 00:16:31 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c5849de5f84ff7fc49d9fefe51021f0a873f6193
Cr-Commit-Position: refs/heads/master@{#375718}

Powered by Google App Engine
This is Rietveld 408576698