base/bind.h - Issue 1699123002: Unify BindState refcount management into the bound arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/bind.h

Issue 1699123002: Unify BindState refcount management into the bound arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/bind.h

diff --git a/base/bind.h b/base/bind.h

index 3a20feb79116c3b95179d6bdd25fe5e7f859d41d..46dbb913bee1d0bc17825fec1dbced0719c1b350 100644

--- a/base/bind.h

+++ b/base/bind.h

@@ -55,7 +55,7 @@ struct MakeUnboundRunTypeImpl {

typename BindState<

typename FunctorTraits<Functor>::RunnableType,

typename FunctorTraits<Functor>::RunType,

- typename std::decay<Args>::type...>::UnboundRunType;

+ Args...>::UnboundRunType;

};

} // namespace internal

@@ -100,8 +100,7 @@ Bind(Functor functor, Args&&... args) {

!internal::HasRefCountedParamAsRawPtr<is_method, Args...>::value,

"a parameter is a refcounted type and needs scoped_refptr");

- using BindState = internal::BindState<

- RunnableType, RunType, typename std::decay<Args>::type...>;

+ using BindState = internal::BindState<RunnableType, RunType, Args...>;

return Callback<typename BindState::UnboundRunType>(

new BindState(internal::MakeRunnable(functor),

« no previous file with comments | « no previous file | base/bind_helpers.h » ('j') | no next file with comments »