Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699043003: Revert the debugging changes that added vm abort flag and core dumps. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert the debugging changes that added vm abort flag and core dumps. Revert "Add '--abort-on-assertion-errors' to test runner's dart2js commands." This reverts commit a8e54625dadf91676f19ed3278b68824ff66f294. Revert "Add abort-on-assertion flag to dart2js unit test runner." This reverts commit b42443bd260680479dfc5cf5de558f133dfb17b7. Revert "Enable coredumps for dart2js unit tests on buildbot." This reverts commit 5c8b76734c372a3a5f82690bf21e6f6ba4b4a10b. BUG=https://github.com/dart-lang/sdk/issues/25782 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/eafdd42501ce3b6745612193d7db0521b2637bbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M tools/bots/bot_utils.py View 2 chunks +0 lines, -18 lines 0 comments Download
M tools/bots/compiler.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 10 months ago (2016-02-16 12:55:51 UTC) #2
Vyacheslav Egorov (Google)
rubberstamp lgtm
4 years, 10 months ago (2016-02-16 14:26:38 UTC) #3
Bill Hesse
4 years, 10 months ago (2016-02-16 14:36:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
eafdd42501ce3b6745612193d7db0521b2637bbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698