Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1699043003: Revert the debugging changes that added vm abort flag and core dumps. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/compiler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 2a3c83cff89d2cbcdf4be01664c6463f27d75066..931a53d79466251cfd0c946365e968f68e334962 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -217,22 +217,11 @@ class Dart2xCompilerConfiguration extends CompilerConfiguration {
arguments = new List.from(arguments);
arguments.add('--out=$outputFileName');
- // We want all dart2js compilers to run the vm with the
- // --abort-on-assertion-errors flag.
- // We have allowed constant maps as environmentOverrides,
- // so we modify a new map.
- var newOverrides = {'DART_VM_OPTIONS': '--abort-on-assertion-errors'};
- if (environmentOverrides != null) {
- newOverrides.addAll(environmentOverrides);
- if (environmentOverrides.containsKey('DART_VM_OPTIONS')) {
- newOverrides['DART_VM_OPTIONS'] += ' --abort-on-assertion-errors';
- }
- }
return commandBuilder.getCompilationCommand(
moniker, outputFileName, !useSdk,
bootstrapDependencies(buildDir),
computeCompilerPath(buildDir),
- arguments, newOverrides);
+ arguments, environmentOverrides);
}
List<Uri> bootstrapDependencies(String buildDir) {
« no previous file with comments | « tools/bots/compiler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698