[Interpreter] Push BytecodeArray onto interpreted stack frames.

[Interpreter] Push BytecodeArray onto interpreted stack frames.

Replaces the push of the dispatch table on the interpreted stack frame with a
push of the bytecode array. This enables the debugger to replace the bytecode
array with a patched version containing breakpoints.

BUG=v8:4690
LOG=N

Committed: https://crrev.com/27204d6e05cd6c0d391f3bb643cedc5cfc43fac0
Cr-Commit-Position: refs/heads/master@{#34032}

[rmcilroy, 2016-02-16 09:47:23]

https://codereview.chromium.org/1699013002/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/1699013002/diff/1/test/mjsunit/mjsunit.status...
test/mjsunit/mjsunit.status:841: 'harmony/default-parameters-debug': [FAIL],
I have a follow-up CL which fixes this test failure (+ one other)

[rmcilroy, 2016-02-16 09:47:39]

rmcilroy@chromium.org changed reviewers:
+ yangguo@chromium.org

[rmcilroy, 2016-02-16 09:47:39]

PTAL, thanks.

[rmcilroy, 2016-02-16 09:49:41]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-02-16 09:49:59]

https://codereview.chromium.org/1699013002/diff/20001/test/mjsunit/mjsunit.st...
File test/mjsunit/mjsunit.status (right):

https://codereview.chromium.org/1699013002/diff/20001/test/mjsunit/mjsunit.st...
test/mjsunit/mjsunit.status:841: 'harmony/default-parameters-debug': [FAIL],
I have a follow-up CL in the works which fixes this test failure (+ one other)

[Yang, 2016-02-16 09:58:53]

How come we don't have to do the same change in Generate_EnterBytecodeDispatch?

[rmcilroy, 2016-02-16 10:08:05]

On 2016/02/16 09:58:53, Yang wrote:
> How come we don't have to do the same change in
Generate_EnterBytecodeDispatch?

Good point, I missed this. Will do that too, thanks.

[rmcilroy, 2016-02-16 10:55:22]

On 2016/02/16 10:08:05, rmcilroy wrote:
> On 2016/02/16 09:58:53, Yang wrote:
> > How come we don't have to do the same change in
> Generate_EnterBytecodeDispatch?
> 
> Good point, I missed this. Will do that too, thanks.

Done, PTAL, thanks.

[Yang, 2016-02-16 11:37:29]

lgtm. thanks.

[rmcilroy, 2016-02-16 11:39:33]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-02-16 11:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1699013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1699013002/40001

[commit-bot: I haz the power, 2016-02-16 12:35:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-16 12:36:22]

Description was changed from

==========
[Interpreter] Push BytecodeArray onto interpreted stack frames.

Replaces the push of the dispatch table on the interpreted stack frame with a
push of the bytecode array. This enables the debugger to replace the bytecode
array with a patched version containing breakpoints.

BUG=v8:4690
LOG=N
==========

to

==========
[Interpreter] Push BytecodeArray onto interpreted stack frames.

Replaces the push of the dispatch table on the interpreted stack frame with a
push of the bytecode array. This enables the debugger to replace the bytecode
array with a patched version containing breakpoints.

BUG=v8:4690
LOG=N

Committed: https://crrev.com/27204d6e05cd6c0d391f3bb643cedc5cfc43fac0
Cr-Commit-Position: refs/heads/master@{#34032}
==========

[commit-bot: I haz the power, 2016-02-16 12:36:23]

Patchset 2 (id:??) landed as
https://crrev.com/27204d6e05cd6c0d391f3bb643cedc5cfc43fac0
Cr-Commit-Position: refs/heads/master@{#34032}