Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1697223003: [Interpreter] GetExpression(0) in InterpretedFrames gets first local. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_push_bca
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] GetExpression(0) in InterpretedFrames gets first local. Various places assume that GetExpression returns the locals for a frame. Modify InterpretedFrames such that GetExpression(0) returns the first local, not the fixed parts of the interpreter frame. BUG=v8:4690, v8:4680 LOG=N Committed: https://crrev.com/c0c5d1310c9e1c7d88c76630c7f8964deddb12e5 Cr-Commit-Position: refs/heads/master@{#34040}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M src/frames.h View 1 5 chunks +10 lines, -6 lines 0 comments Download
M src/frames.cc View 4 chunks +29 lines, -33 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
rmcilroy
Yang, PTAL, thanks.
4 years, 10 months ago (2016-02-16 12:01:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697223003/20001
4 years, 10 months ago (2016-02-16 12:01:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 12:34:21 UTC) #6
Yang
On 2016/02/16 12:34:21, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-02-16 15:26:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697223003/20001
4 years, 10 months ago (2016-02-16 15:30:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 15:33:59 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 15:34:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0c5d1310c9e1c7d88c76630c7f8964deddb12e5
Cr-Commit-Position: refs/heads/master@{#34040}

Powered by Google App Engine
This is Rietveld 408576698