third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html - Issue 1698973002: Exempt Save-Data header from CORS preflight request check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html

Issue 1698973002: Exempt Save-Data header from CORS preflight request check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added layout test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400.html b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html

similarity index 79%

copy from third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400.html

copy to third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html

index d59d53586e306e8e675d9ea6ae10e4847bfd311e..e8cbda9267d629f83c32ecc94dc762004528b05b 100644

--- a/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-request-invalid-status-400.html

+++ b/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html

@@ -1,8 +1,10 @@

<html>

<body>

-<p>Test that preflight requests with invalid status code results in error. Should print PASS.</p>

+<p>Test that 'Save-Data' header is treated as a simple header and preflight request is not created. Should print PASS.</p>

+window.internals.settings.setDataSaverEnabled(true);

function log(message) {

document.getElementById("log").innerHTML += message + "<br>";

}

@@ -14,17 +16,17 @@ if (window.layoutTestController) {

var xhr = new XMLHttpRequest();

xhr.open("GET", "http://localhost:8000/xmlhttprequest/resources/access-control-preflight-request-invalid-status.php?code=400");

-xhr.setRequestHeader("X-Custom-Header", "PASS");

xhr.onerror = function () {

- log("PASS");

+ log("FAIL");

if (window.layoutTestController)

layoutTestController.notifyDone();

};

xhr.onload = function () {

- log("FAIL");

+ log("PASS");

if (window.layoutTestController)

layoutTestController.notifyDone();

};

xhr.send();

</script>

+</body>

</html>