Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 1698973002: Exempt Save-Data header from CORS preflight request check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added layout test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 819c6d762d630d07043ba8769677e472c2ffb63b..0da138b1caffc0d6487d59aeb8a064e426720634 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -695,6 +695,14 @@ void CreateWebUsbPermissionBubble(
}
#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
+bool GetDataSaverEnabledPref(const PrefService* prefs) {
+ // Enable data saver only when data saver pref is enabled and not part of
+ // "Disabled" group of "SaveDataHeader" experiment.
+ return prefs->GetBoolean(prefs::kDataSaverEnabled) &&
+ base::FieldTrialList::FindFullName("SaveDataHeader")
+ .compare("Disabled");
+}
+
} // namespace
ChromeContentBrowserClient::ChromeContentBrowserClient()
@@ -2379,8 +2387,7 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(
web_prefs->strict_powerful_feature_restrictions = true;
}
- web_prefs->data_saver_enabled =
- prefs->GetBoolean(prefs::kDataSaverEnabled);
+ web_prefs->data_saver_enabled = GetDataSaverEnabledPref(prefs);
for (size_t i = 0; i < extra_parts_.size(); ++i)
extra_parts_[i]->OverrideWebkitPrefs(rvh, web_prefs);
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-preflight-data-saver.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698