[es6] [interpreter] Add tail calls support to Ignition.

[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698, v8:4687
LOG=N

Committed: https://crrev.com/32b4bc138252d9773cc90b2d4aae78d98844bba1
Cr-Commit-Position: refs/heads/master@{#34083}

[Igor Sheludko, 2016-02-16 10:45:42]

Description was changed from

==========
[es6] Make Ignition support tail calls.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698
LOG=N
==========

to

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698
LOG=N
==========

[Igor Sheludko, 2016-02-16 10:47:58]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-02-16 11:18:19]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-02-16 11:23:03]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-02-16 11:23:10]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 11:23:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/60001

[commit-bot: I haz the power, 2016-02-16 11:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 11:48:47]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13810)

[Igor Sheludko, 2016-02-16 12:13:24]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 12:13:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/80001

[Igor Sheludko, 2016-02-16 12:40:37]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[Igor Sheludko, 2016-02-16 12:40:37]

Ross, PTAL
Benedikt, FYI

[rmcilroy, 2016-02-16 12:48:44]

Description was changed from

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698
LOG=N
==========

to

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698,v8:4687
LOG=N
==========

[commit-bot: I haz the power, 2016-02-16 13:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 13:03:02]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)

[Igor Sheludko, 2016-02-16 14:17:03]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 14:17:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/100001

[commit-bot: I haz the power, 2016-02-16 14:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 14:40:21]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-02-16 17:16:58]

Nice, LGTM, thanks! 

Could you please make sure to coordinate with Mythri on her CL which moves our
calls to be via CallICs (https://codereview.chromium.org/1688283003/)

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
src/interpreter/bytecode-array-builder.cc:1093: : Bytecode::kCall;
Could you move this to a BytecodeForTailCallMode() helper (
 down near the other helpers like BytecodeForCreateArguments) with a switch (to
ensure we know if any other modes are added to TailCallMode)

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
src/interpreter/bytecode-array-builder.cc:1104: Output(bytecode,
callable.ToRawOperand(), receiver_args.ToRawOperand(),
Please add kCall and kTailCall to BytecodeForWideOperands and use that to
convert the bytecode here (moving the above declaration of Bytecode out of the
if block)

[Igor Sheludko, 2016-02-17 14:07:08]

Addressed comments, going to land.

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
File src/interpreter/bytecode-array-builder.cc (right):

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
src/interpreter/bytecode-array-builder.cc:1093: : Bytecode::kCall;
On 2016/02/16 17:16:58, rmcilroy wrote:
> Could you move this to a BytecodeForTailCallMode() helper (
>  down near the other helpers like BytecodeForCreateArguments) with a switch
(to
> ensure we know if any other modes are added to TailCallMode)

Done.

https://codereview.chromium.org/1698273003/diff/100001/src/interpreter/byteco...
src/interpreter/bytecode-array-builder.cc:1104: Output(bytecode,
callable.ToRawOperand(), receiver_args.ToRawOperand(),
On 2016/02/16 17:16:58, rmcilroy wrote:
> Please add kCall and kTailCall to BytecodeForWideOperands and use that to
> convert the bytecode here (moving the above declaration of Bytecode out of the
> if block) 

Done.

[Igor Sheludko, 2016-02-17 14:07:17]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 14:07:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/120001

[commit-bot: I haz the power, 2016-02-17 14:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 14:08:19]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13894)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/1509)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/1505)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15578)

[Igor Sheludko, 2016-02-17 14:22:41]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 14:22:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/160001

[commit-bot: I haz the power, 2016-02-17 14:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 14:53:33]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-02-17 15:00:01]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-02-17 15:00:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1698273003/#ps160001
(title: "Fixed Bytecodes::IsCallOrNew()")

[commit-bot: I haz the power, 2016-02-17 15:00:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/160001

[commit-bot: I haz the power, 2016-02-17 15:02:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 15:02:44]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11119)

[Michael Starzinger, 2016-02-17 15:11:44]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-02-17 15:11:45]

LGTM. Nice!

[Igor Sheludko, 2016-02-17 15:12:14]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-02-17 15:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1698273003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1698273003/160001

[commit-bot: I haz the power, 2016-02-17 15:19:09]

Description was changed from

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698,v8:4687
LOG=N
==========

to

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698,v8:4687
LOG=N
==========

[commit-bot: I haz the power, 2016-02-17 15:19:09]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-02-17 15:20:01]

Description was changed from

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698,v8:4687
LOG=N
==========

to

==========
[es6] [interpreter] Add tail calls support to Ignition.

This CL introduces two new bytecodes TailCall and TailCallWide.

BUG=v8:4698,v8:4687
LOG=N

Committed: https://crrev.com/32b4bc138252d9773cc90b2d4aae78d98844bba1
Cr-Commit-Position: refs/heads/master@{#34083}
==========

[commit-bot: I haz the power, 2016-02-17 15:20:02]

Patchset 6 (id:??) landed as
https://crrev.com/32b4bc138252d9773cc90b2d4aae78d98844bba1
Cr-Commit-Position: refs/heads/master@{#34083}