[es6] [interpreter] Add tail calls support to Ignition.

src/interpreter/bytecode-array-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/compiler.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
@@ skipping 1065 matching lines @@
   if (!exit_seen_in_block_) {
     LoadUndefined();
     SetReturnPosition(literal);
     Return();
   }
 }
 
 BytecodeArrayBuilder& BytecodeArrayBuilder::Call(Register callable,
                                                  Register receiver_args,
                                                  size_t receiver_args_count,
-                                                 int feedback_slot) {
+                                                 int feedback_slot,
+                                                 TailCallMode tail_call_mode) {
   if (FitsInReg8Operand(callable) && FitsInReg8Operand(receiver_args) &&
       FitsInIdx8Operand(receiver_args_count) &&
       FitsInIdx8Operand(feedback_slot)) {
-    Output(Bytecode::kCall, callable.ToRawOperand(),
-           receiver_args.ToRawOperand(),
+    Bytecode bytecode = tail_call_mode == TailCallMode::kAllow
+                            ? Bytecode::kTailCall
+                            : Bytecode::kCall;

[rmcilroy, 2016/02/16 17:16:58]

Could you move this to a BytecodeForTailCallMode() helper (
 down near the other helpers like BytecodeForCreateArguments) with a switch (to
ensure we know if any other modes are added to TailCallMode)

[Igor Sheludko, 2016/02/17 14:07:08]

Done.

+    Output(bytecode, callable.ToRawOperand(), receiver_args.ToRawOperand(),
            static_cast<uint8_t>(receiver_args_count),
            static_cast<uint8_t>(feedback_slot));
   } else if (FitsInReg16Operand(callable) &&
              FitsInReg16Operand(receiver_args) &&
              FitsInIdx16Operand(receiver_args_count) &&
              FitsInIdx16Operand(feedback_slot)) {
-    Output(Bytecode::kCallWide, callable.ToRawOperand(),
-           receiver_args.ToRawOperand(),
+    Bytecode bytecode = tail_call_mode == TailCallMode::kAllow
+                            ? Bytecode::kTailCallWide
+                            : Bytecode::kCallWide;
+    Output(bytecode, callable.ToRawOperand(), receiver_args.ToRawOperand(),

[rmcilroy, 2016/02/16 17:16:58]

Please add kCall and kTailCall to BytecodeForWideOperands and use that to
convert the bytecode here (moving the above declaration of Bytecode out of the
if block) 

[Igor Sheludko, 2016/02/17 14:07:08]

Done.

            static_cast<uint16_t>(receiver_args_count),
            static_cast<uint16_t>(feedback_slot));
   } else {
     UNIMPLEMENTED();
   }
   return *this;
 }
 
 BytecodeArrayBuilder& BytecodeArrayBuilder::New(Register constructor,
                                                 Register first_arg,
@@ skipping 578 matching lines @@
 }
 
 // static
 bool BytecodeArrayBuilder::FitsInReg16OperandUntranslated(Register value) {
   return value.is_short_operand();
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8