Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1698143002: Combine 4 bools into GeometryInfoFlags. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine 4 bools into GeometryInfoFlags. This should be more readable and less error-prone than passing 4 bool parameters to LayoutGeometryMap::push(). "false, false, false, false" -> "0" Committed: https://crrev.com/4918c78cf478245ec95aa512115ffe34f7f1f33f Cr-Commit-Position: refs/heads/master@{#375600}

Patch Set 1 #

Patch Set 2 : oops #

Total comments: 2

Patch Set 3 : Bitshift. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 9 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h View 1 2 2 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mstensho (USE GERRIT)
Hi Chris, is this something we want?
4 years, 10 months ago (2016-02-15 20:52:34 UTC) #2
leviw_travelin_and_unemployed
(American) Holiday drive-by nit! https://codereview.chromium.org/1698143002/diff/20001/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h File third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h (right): https://codereview.chromium.org/1698143002/diff/20001/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h#newcode40 third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h:40: AccumulatingTransform = 1, Nit: bitshift ...
4 years, 10 months ago (2016-02-16 01:41:57 UTC) #4
leviw_travelin_and_unemployed
(Also I like flags more than stream-o-bools but I'mma let Chris finish https://www.youtube.com/watch?v=e4Q7zuci5n8)
4 years, 10 months ago (2016-02-16 01:43:39 UTC) #5
mstensho (USE GERRIT)
https://codereview.chromium.org/1698143002/diff/20001/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h File third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h (right): https://codereview.chromium.org/1698143002/diff/20001/third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h#newcode40 third_party/WebKit/Source/core/layout/LayoutGeometryMapStep.h:40: AccumulatingTransform = 1, On 2016/02/16 01:41:57, leviw wrote: > ...
4 years, 10 months ago (2016-02-16 10:15:04 UTC) #6
chrishtr
lgtm
4 years, 10 months ago (2016-02-16 17:25:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698143002/40001
4 years, 10 months ago (2016-02-16 17:25:18 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-16 17:29:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:53:22 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4918c78cf478245ec95aa512115ffe34f7f1f33f
Cr-Commit-Position: refs/heads/master@{#375600}

Powered by Google App Engine
This is Rietveld 408576698