third_party/WebKit/Source/core/layout/LayoutGeometryMap.h - Issue 1698143002: Combine 4 bools into GeometryInfoFlags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGeometryMap.h

Issue 1698143002: Combine 4 bools into GeometryInfoFlags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bitshift. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGeometryMap.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h

index 78436b0d4d8bebb0684b2affb8f7b255259c6972..315026fc97f8100b679411fdcdeedb34f26058b5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGeometryMap.h

@@ -72,8 +72,8 @@ public:

// Push geometry info between this layoutObject and some ancestor. The ancestor must be its container() or some

// stacking context between the layoutObject and its container.

- void push(const LayoutObject*, const LayoutSize&, bool accumulatingTransform = false, bool isNonUniform = false, bool isFixedPosition = false, bool hasTransform = false, LayoutSize offsetForFixedPosition = LayoutSize());

- void push(const LayoutObject*, const TransformationMatrix&, bool accumulatingTransform = false, bool isNonUniform = false, bool isFixedPosition = false, bool hasTransform = false, LayoutSize offsetForFixedPosition = LayoutSize());

+ void push(const LayoutObject*, const LayoutSize&, GeometryInfoFlags = 0, LayoutSize offsetForFixedPosition = LayoutSize());

+ void push(const LayoutObject*, const TransformationMatrix&, GeometryInfoFlags = 0, LayoutSize offsetForFixedPosition = LayoutSize());

private:

void popMappingsToAncestor(const LayoutBoxModelObject*);