Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1698113002: [turbofan] Make pipeline.h independent of compiler.h. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make pipeline.h independent of compiler.h. Eventually compiler.h might need to depend on the Pipeline to manage its life cycle for concurrent recompilation, so we should not have the cyclic include dependency here. R=jarin@chromium.org Committed: https://crrev.com/73eae4c26a2943ce17529cbe024b118be71ec958 Cr-Commit-Position: refs/heads/master@{#34000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/compiler/pipeline.h View 3 chunks +10 lines, -7 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-15 11:54:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698113002/1
4 years, 10 months ago (2016-02-15 11:54:56 UTC) #3
Benedikt Meurer
Hey Jaro, Here's a first easy change towards concurrent recompilation with proper pipeline lifecycle management. ...
4 years, 10 months ago (2016-02-15 12:11:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 12:13:45 UTC) #6
Jarin
lgtm!
4 years, 10 months ago (2016-02-15 15:13:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1698113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1698113002/1
4 years, 10 months ago (2016-02-15 17:25:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 17:27:10 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 17:27:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73eae4c26a2943ce17529cbe024b118be71ec958
Cr-Commit-Position: refs/heads/master@{#34000}

Powered by Google App Engine
This is Rietveld 408576698