Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1697133002: [turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_Pipeline
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Combine GenericLoweringPhase and ChangeLoweringPhase. There's no need to use a dedicated ChangeLoweringPhase before we go to GenericLoweringPhase; instead that change lowering (which is really simplified lowering by now) should run together with generic lowering. R=jarin@chromium.org Committed: https://crrev.com/0835ed9caf44427755065eb45f9187678ec9844c Cr-Commit-Position: refs/heads/master@{#34008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -30 lines) Patch
M src/compiler/pipeline.cc View 4 chunks +11 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-15 12:11:16 UTC) #1
Benedikt Meurer
Hey Jaro, No need to have this sequentially, can run together instead. Please take a ...
4 years, 10 months ago (2016-02-15 12:12:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697133002/1
4 years, 10 months ago (2016-02-15 12:13:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 12:58:34 UTC) #6
Jarin
lgtm
4 years, 10 months ago (2016-02-15 15:15:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697133002/1
4 years, 10 months ago (2016-02-15 19:14:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 19:16:16 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0835ed9caf44427755065eb45f9187678ec9844c Cr-Commit-Position: refs/heads/master@{#34008}
4 years, 10 months ago (2016-02-15 19:16:56 UTC) #12
Benedikt Meurer
4 years, 10 months ago (2016-02-16 08:25:07 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1698273002/ by bmeurer@chromium.org.

The reason for reverting is: Seems to tank stuff..

Powered by Google App Engine
This is Rietveld 408576698